From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 769BB10E263 for ; Mon, 26 Jun 2023 22:52:13 +0000 (UTC) Date: Mon, 26 Jun 2023 15:52:11 -0700 Message-ID: <874jmtdeg4.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Anshuman Gupta In-Reply-To: <20230626125045.3699311-3-anshuman.gupta@intel.com> References: <20230626125045.3699311-1-anshuman.gupta@intel.com> <20230626125045.3699311-3-anshuman.gupta@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t v4 2/2] lib/igt_aux: Enable PM Suspend dbg messages List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, 26 Jun 2023 05:50:45 -0700, Anshuman Gupta wrote: > Hi Anshuman, > Enabling PM Suspend dbg messages by turning on > /sys/power/pm_debug_messages switch also adding an > exit handler provision to restore the > pm_debug_messages state. > > v2: > - Fixed sysfs_fd leak. [Badal] > v3: > - Added igt_aux_enable_pm_suspend_dbg() function doc. [Kmail] > > Signed-off-by: Anshuman Gupta > Reviewed-by: Badal Nilawar > --- > lib/igt_aux.c | 35 ++++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/lib/igt_aux.c b/lib/igt_aux.c > index 5eb6d9e270..35263b4519 100644 > --- a/lib/igt_aux.c > +++ b/lib/igt_aux.c > @@ -703,6 +703,7 @@ void igt_print_activity(void) > > static int autoresume_delay; > bool __console_suspend_saved_state; > +bool __pm_debug_messages_state; > > #define SYSFS_MODULE_PRINTK "/sys/module/printk/parameters/" > #define CONSOLE_SUSPEND_DISABLE false > @@ -913,7 +914,7 @@ static bool is_mem_sleep_state_supported(int power_dir, enum igt_mem_sleep state > > static void igt_aux_pm_suspend_dbg_restore_exit_handler(int sig) > { > - int sysfs_fd; > + int sysfs_fd, power_dir; > > sysfs_fd = open(SYSFS_MODULE_PRINTK, O_RDONLY); > > @@ -922,17 +923,30 @@ static void igt_aux_pm_suspend_dbg_restore_exit_handler(int sig) > > igt_sysfs_set_boolean(sysfs_fd, "console_suspend", __console_suspend_saved_state); > close(sysfs_fd); Maybe add an empty line here. > + power_dir = open("/sys/power", O_RDONLY); > + And delete this empty line. > + if (power_dir < 0) > + return; > + > + if (!faccessat(power_dir, "pm_debug_messages", R_OK | W_OK, 0)) > + igt_sysfs_set_boolean(power_dir, "pm_debug_messages", __pm_debug_messages_state); > + > + close(power_dir); > } > > /** > * igt_aux_enable_pm_suspend_dbg: > + * @power_dir: /sys/power/ dir fd > * > * Enhance the System wide suspend/resume debugging by, No comma needed (it's from previous patch). Apart from above nits, lgtm: Reviewed-by: Ashutosh Dixit