From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <SRS0=Vgj9=TF=lists.freedesktop.org=igt-dev-bounces@kernel.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 3B43D10E710
 for <igt-dev@lists.freedesktop.org>; Tue, 22 Feb 2022 19:49:21 +0000 (UTC)
Date: Tue, 22 Feb 2022 11:49:17 -0800
Message-ID: <874k4q7kci.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Jasmine Newsome <jasmine.newsome@intel.com>
In-Reply-To: <20220219013215.3531766-2-jasmine.newsome@intel.com>
References: <20220219013215.3531766-1-jasmine.newsome@intel.com>
 <20220219013215.3531766-2-jasmine.newsome@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts
 as part of the spinner
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Fri, 18 Feb 2022 17:32:14 -0800, Jasmine Newsome wrote:
>
> Save igt_spin_factory info in igt_spin. This will allow
> for access to the actual context within the spinner.
> Previously, only the context id was accessible.

Not sure about the sentence above, not seeing context id as part of
igt_spin_t. Maybe just drop this sentence.

> This might help make spinner code cleaner.

Maybe we can just say something like: Save the opts with which the spin was
created as part of the spin so that the opts are available in case they are
needed. Something like that.

The patch itself is fine, just the commit message needs a tweak. Thanks.