From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E0B76E8A2 for ; Thu, 14 Oct 2021 04:35:37 +0000 (UTC) Date: Wed, 13 Oct 2021 21:18:07 -0700 Message-ID: <874k9ki6io.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20211008065432.15482-6-zbigniew.kempczynski@intel.com> References: <20211008065432.15482-1-zbigniew.kempczynski@intel.com> <20211008065432.15482-6-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 5/7] tests/i915_pm_rpm: Fix invalid alignment List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Thu, 07 Oct 2021 23:54:30 -0700, Zbigniew Kempczy=F1ski wrote: > > In theory kernel requires vma to be power of two aligned, but in > practice inserting vma requires alignment to be at least GTT min > alignment - which is page size atm. Change this alignment from 64->0 > to allow test to run on gens where alignment must be zero in execbuf > as it will be page size aligned anyway. > > Signed-off-by: Zbigniew Kempczy=F1ski > Cc: Petri Latvala > Cc: Ashutosh Dixit > --- > tests/i915/i915_pm_rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c > index 62720d02b..576b4b466 100644 > --- a/tests/i915/i915_pm_rpm.c > +++ b/tests/i915/i915_pm_rpm.c > @@ -1234,7 +1234,7 @@ static void submit_blt_cmd(uint32_t dst_handle, int= dst_size, > relocs[0].write_domain =3D I915_GEM_DOMAIN_RENDER; > > objs[0].handle =3D dst_handle; > - objs[0].alignment =3D 64; > + objs[0].alignment =3D 0; Yes I agree alignment is probably useless in this test: Reviewed-by: Ashutosh Dixit