From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>, igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: Re: [igt-dev] [RFC i-g-t] LPSP igt test on TGL
Date: Thu, 27 Feb 2020 14:44:18 +0200 [thread overview]
Message-ID: <874kvcryhp.fsf@intel.com> (raw)
In-Reply-To: <20200227084149.588-1-anshuman.gupta@intel.com>
On Thu, 27 Feb 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> Above block diagram depicts lpsp on TGL, while earlier development of
> lpsp igt test it has been assumed that every non-edp panel is not a
> lpsp panel but it is not true on TGL, any HDMI/DP panel connected on
> pipe A and connected to PORT_{A,B,C} is lpsp panel, and DSI panel is
> also lpsp panel.
>
> Currently i915_pm_lpsp igt has been categorized in edp-native and non-edp subtest.
> non-edp subtest require the fix to validate the lpsp panels.
> My solution approach to check the port on which DP/HDMI connector is currently
> connected.
> if (port <= PORT_C)
> lpsp_should_be_enabled.
> else
> lpsp_should_be_disabled.
>
> Currently there are two igt i915_pm_lpsp, i915_pm_rpm require to know
> the port of DP/HDMI connector, so we need a igt library function for
> that.
>
> I am looking to parse the i915_display_info to get the port
> information, but at same time it seems a fragile solution to me as any
> change in i915_display_info will break the test, but i don't have any
> other idea to get the port information.
>
> Please provide your opinion and feedback for the above solution approach.
I'd add a connector specific debugfs file that tells you whether LPSS
(Low Power Single Pipe, for those who want to know what the acronym
means) is possible and whether it's enabled. Alternatively add the info
about LPSS to i915_display_info. But AFAICT there's no need for
userspace to know about the port. This also avoids reading the
HSW_PWR_WELL_CTL2 register directly.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-27 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 8:41 [igt-dev] [RFC i-g-t] LPSP igt test on TGL Anshuman Gupta
2020-02-27 12:44 ` Jani Nikula [this message]
2020-03-03 4:27 ` Anshuman Gupta
2020-03-03 8:34 ` Jani Nikula
2020-03-03 8:45 ` Anshuman Gupta
2020-03-03 10:44 ` Jani Nikula
2020-03-03 12:20 ` Anshuman Gupta
2020-02-27 12:55 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kvcryhp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox