From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF8DDCD37AA for ; Tue, 3 Sep 2024 20:12:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 779ED10E361; Tue, 3 Sep 2024 20:12:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SUZ7KWvC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68BB510E361 for ; Tue, 3 Sep 2024 20:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725394324; x=1756930324; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=6WjypVrgl4gJKVUbh9pGYrD0LHNOutbkp/wgc8oXa00=; b=SUZ7KWvCBQP271coU6GDzaN6vZvEQxZNO+B15GwQi2c8uOrthfRj/dy1 BsjjIbGz+2pwCn+s07xdbrrztthgSTEqrsNMewaIRTUkvTW9REc3ueluo JhAYREyHBvO7YpMZDy8QzCcLA6jJ5bJ3Xus/SFSX4MQgnHd7THVHGQzkv 5xDetmkquZBA6L++YgQKcIp8zJopgpVEiIV38mw3Nb9MvAZhFJXL+XXxH 7hA1R6pcF2W93haW3DzPYWDkCgmVYBN2wVexE0hP0cj8M4C/QmqX8SkQv im/IXzQ4eNayQ/TV0Mam7uuMWFZgX8JieZ2oid7vpgGI26a9M2wpvX7Kg w==; X-CSE-ConnectionGUID: ct7qMAlTQ7ej8b4zIK70lQ== X-CSE-MsgGUID: JKDL4/r4RbSeDVgLurkEqQ== X-IronPort-AV: E=McAfee;i="6700,10204,11184"; a="27776435" X-IronPort-AV: E=Sophos;i="6.10,199,1719903600"; d="scan'208";a="27776435" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 13:12:04 -0700 X-CSE-ConnectionGUID: +fLbGYn+RV29+bhq6pOJlQ== X-CSE-MsgGUID: u8h5M0qGSeuhBtBCHCJEvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,199,1719903600"; d="scan'208";a="95829803" Received: from jtuanzol-mobl2.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.129.72]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 13:12:04 -0700 Date: Tue, 03 Sep 2024 12:52:25 -0700 Message-ID: <875xrczf9i.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza Cc: Subject: Re: [PATCH i-g-t v2 3/4] xe/oa: Update scripts to support BMG In-Reply-To: <20240903132436.8337-3-jose.souza@intel.com> References: <20240903132436.8337-1-jose.souza@intel.com> <20240903132436.8337-3-jose.souza@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 03 Sep 2024 06:24:35 -0700, Jos=E9 Roberto de Souza wrote: > Thanks for the patches Jose. This is also: Reviewed-by: Ashutosh Dixit Though one more change is needed, at least in IGT, to use BMG, here: In lib/xe/xe_oa.c: struct intel_xe_perf * intel_xe_perf_for_devinfo(uint32_t device_id, { ... } else if (intel_graphics_ver(device_id) >=3D IP_VER(20, 0)) { intel_xe_perf_load_metrics_lnl(perf); ... } If this is not needed for Mesa, I can make the change for IGT. But for now this series is R-b'd.