From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 04/17] Add basic PXP testing of buffer and context alloc
Date: Sun, 16 May 2021 20:10:20 -0700 [thread overview]
Message-ID: <875yzirr6r.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210515230142.1816456-5-alan.previn.teres.alexis@intel.com>
On Sat, 15 May 2021 16:01:29 -0700, Alan Previn wrote:
>
> +static void test_ctx_mod_protected_on_to_off(int i915)
> +{
> + int ret;
> + uint32_t ctx;
> +
> + ret = create_ctx_with_params(i915, true, true, true, false, &ctx);
> + igt_assert_eq(ret, 0);
If we are going to spin another rev, I'd follow a uniform style here. That
is, have a single statement which combines the function call and the
igt_assert_eq as is done below (basically get rid of ret if possible).
> + igt_assert_eq(get_ctx_protected_param(i915, ctx), 1);
> + igt_assert_eq(get_ctx_recovery_param(i915, ctx), 0);
> + ret = modify_ctx_param(i915, ctx, CHANGE_PARAM_PROTECTED, false);
> + igt_assert_eq(ret, -EPERM);
> + igt_assert_eq(get_ctx_protected_param(i915, ctx), 1);
> + igt_assert_eq(get_ctx_recovery_param(i915, ctx), 0);
> + gem_context_destroy(i915, ctx);
> +}
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-05-17 3:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 23:01 [igt-dev] [PATCH i-g-t 00/17] Introduce PXP Test Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 01/17] Sync i915_drm.h UAPI from kernel Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 02/17] Add PXP UAPI support in i915_drm.h Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 03/17] Upadte IOCTL wrapper with DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 04/17] Add basic PXP testing of buffer and context alloc Alan Previn
2021-05-17 3:10 ` Dixit, Ashutosh [this message]
2021-05-17 10:26 ` Petri Latvala
2021-05-17 14:42 ` Dixit, Ashutosh
2021-05-17 14:50 ` Petri Latvala
2021-05-17 16:34 ` Teres Alexis, Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 05/17] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 06/17] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 07/17] Add MI_SET_APPID instruction definition Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 08/17] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 09/17] Add subtest to copy raw source to protected dest Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 10/17] Add test where both src and dest are protected Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 11/17] Verify PXP teardown occured through suspend-resume Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 12/17] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 13/17] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 14/17] Verify execbuf ok with stale prot-buff and regular context Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 15/17] Ensure RESET_STAT reports invalidated protected context Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 16/17] Verify protected surfaces are dma buffer sharable Alan Previn
2021-05-15 23:01 ` [igt-dev] [PATCH i-g-t 17/17] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-05-16 0:07 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev4) Patchwork
2021-05-16 2:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-05-18 10:33 [igt-dev] [PATCH i-g-t 00/17] Introduce PXP Test Alan Previn
2021-05-18 10:33 ` [igt-dev] [PATCH i-g-t 04/17] Add basic PXP testing of buffer and context alloc Alan Previn
2021-06-02 20:23 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yzirr6r.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox