From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0E3A6E055 for ; Fri, 30 Oct 2020 23:06:31 +0000 (UTC) Date: Fri, 30 Oct 2020 16:06:29 -0700 Message-ID: <875z6rz53e.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20201030225548.7444-1-umesh.nerlige.ramappa@intel.com> References: <20201030225548.7444-1-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Fri, 30 Oct 2020 15:55:48 -0700, Umesh Nerlige Ramappa wrote: > @@ -4806,6 +4807,13 @@ igt_main > igt_fixture { > struct stat sb; > > + /* > + * Prior tests may have unloaded i915 or failed while > + * loading/unloading i915. Load i915 here before we stat the > + * files. > + */ > + igt_i915_driver_load(NULL); > + I was thinking that the original if () was also ok because there will be an additional igt_debug() if the module is already loaded and the if will avoid that. Anyway you decide what to do, either way: Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev