From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A23FDC369AB for ; Fri, 18 Apr 2025 20:45:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27FB710E2C6; Fri, 18 Apr 2025 20:45:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UmhUdsYd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34E6110E2C4 for ; Fri, 18 Apr 2025 20:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745009119; x=1776545119; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5FLyprvJuRUVP0ORWnutZC6HgBKdhm1ZJuwCfc+jR/k=; b=UmhUdsYd1Im5H3mHm+IT5S8ZnrRSIifv+bC9I2PJ5IU+lBvZ5ih+3lCg MMphol9ecQnvq9LdDw29vNQmlm8a4pq3vl5CdZXWPZVDCbgZt5yubOxk5 o2iqznsL5zt1ONzby2dSVtEN7flquJlOpzS+DkwQmS9EYk4xEL7OKc0Ca J8WfQgfkP0RUOI/N32hZR8YgXFgC9Kqeo6r0fMGl7WX5B6+ClChj2t6WK /JBV6VTn4Q4gojuBEnTrkeAAyYZNh6BaG+RAdA1rxah1VLuojocwLlf1n y5wAmwv9dUEnfytmhE6c84U4fxcjoRV3oAxg67h/QqkcZvO2aAiJC9SA3 A==; X-CSE-ConnectionGUID: XRCz7shPQvaV7AFvc7kDbg== X-CSE-MsgGUID: +sWTCSbARwKVHdR9G8m/VQ== X-IronPort-AV: E=McAfee;i="6700,10204,11407"; a="64050219" X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="64050219" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2025 13:45:18 -0700 X-CSE-ConnectionGUID: O9kveoBTRdW16luZIeDO9g== X-CSE-MsgGUID: vX/bXy13QNGGruUQaDOBUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="131500763" Received: from smuhamma-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.96.160]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2025 13:45:17 -0700 Date: Fri, 18 Apr 2025 13:45:16 -0700 Message-ID: <877c3hgpwj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: , , , Subject: Re: [PATCH] tests/intel/xe_oa: Remove buffer overflow guard from buffer-size tests In-Reply-To: <20250418204203.341078-1-jonathan.cavitt@intel.com> References: <20250418204203.341078-1-jonathan.cavitt@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 18 Apr 2025 13:42:02 -0700, Jonathan Cavitt wrote: > > The guard was a holdover from i915 that is not relevant to Xe because > the buffer contents are preserved during an overflow. Remove the check. > > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4541 > Suggested-by: Umesh Nerlige Ramappa > Suggested-by: Ashutosh Dixit > Signed-off-by: Jonathan Cavitt > --- > tests/intel/xe_oa.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 1fc8bfaafe..7d13bd340a 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2503,10 +2503,6 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b > while (total_len < buf_size && > ((len = read(stream_fd, &buf[total_len], buf_size - total_len)) > 0 || > (len == -1 && (errno == EINTR || errno == EIO)))) { > - if (errno == EIO) { > - oa_status = get_stream_status(stream_fd); > - igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW)); > - } if (errno == EIO) { oa_status = get_stream_status(stream_fd); /* Assert only for default OA buffer size */ if (!oa_buffer_size) igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW)); } > if (len > 0) > total_len += len; > } > -- > 2.43.0 >