From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5256C3601E for ; Thu, 10 Apr 2025 20:33:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A25210EA6A; Thu, 10 Apr 2025 20:33:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="U5X2gFfN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BAB810EA78 for ; Thu, 10 Apr 2025 20:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744317233; x=1775853233; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=r8G2CY2owoNJtOUAJDifqdPdAj5X0kX8VlkSAooQ71U=; b=U5X2gFfNiaNxcua4umy0no/IZeae6HpY9mCAKNwkzFTI7SsZcQQv5kfU pPUwjYI5lvGAeiaRS71loS2qVffQInRTCgFZOyTH0ozjc5TwRUkXBtqPq VdFfOgrChBY9pW7uJa050DiEtSHD8BCHVRI8AXTUH/ygGMtGek6yTi3fF g+Hype6v3pH6RYF47ybn3SiQQkdPD7hiUUNDYkzYBMnUJnUZqy74k68wp mLc5xum/PPW8eSiLFiLCeQypFBdc/1OCnTWvx3Zk0tshuLtX82Kc+5G3K +65haFk3987X06JKcypZCQnUK/L+dqSZ8vJkJOSUk82hjufabacBaHZaO g==; X-CSE-ConnectionGUID: vfyvlUDkTmOPqRxBMurSTw== X-CSE-MsgGUID: jgAw3wRMQDaOKtg/QrRxUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11400"; a="45952609" X-IronPort-AV: E=Sophos;i="6.15,203,1739865600"; d="scan'208";a="45952609" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 13:33:45 -0700 X-CSE-ConnectionGUID: KgQ5Hd1JSHuNNpMD1OnjXQ== X-CSE-MsgGUID: FxcZOh/iRNeosH8QYdId1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,203,1739865600"; d="scan'208";a="159979235" Received: from makealii-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.57.82]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 13:33:45 -0700 Date: Thu, 10 Apr 2025 13:33:44 -0700 Message-ID: <877c3reoyf.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t] tests/intel/xe_oa: Get stream status on read error In-Reply-To: <20250409233441.143402-1-umesh.nerlige.ramappa@intel.com> References: <20250409233441.143402-1-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 09 Apr 2025 16:34:41 -0700, Umesh Nerlige Ramappa wrote: > > Whenever read fails, get stream status so we know the state of OA status > bits. > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 67acc74b3279..f3521c3d602e 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2294,6 +2294,7 @@ static void test_polling_small_buf(void) > errno = 0; > ret = read(stream_fd, buf, sizeof(buf)); > igt_assert_eq(ret, -1); > + get_stream_status(stream_fd); > igt_assert_eq(errno, ENOSPC); > > /* Poll with 0 timeout and expect POLLIN flag to be set */ > @@ -2568,6 +2569,7 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe) > errno = 0; > ret = read(stream_fd, buf, sizeof(buf)); > igt_assert_eq(ret, -1); > + get_stream_status(stream_fd); > igt_assert_eq(errno, EINVAL); > > do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_ENABLE, 0); > @@ -2584,6 +2586,7 @@ test_enable_disable(const struct drm_xe_engine_class_instance *hwe) > /* Ensure num_reports can be read */ > while ((ret = read(stream_fd, buf, sizeof(buf))) < 0 && errno == EINTR) > ; > + get_stream_status(stream_fd); > igt_assert_eq(ret, sizeof(buf)); Here read() is not failing, so maybe we should drop this one? Otherwise: Reviewed-by: Ashutosh Dixit > > __perf_close(stream_fd); > @@ -2727,6 +2730,7 @@ test_non_sampling_read_error(void) > > ret = read(stream_fd, buf, sizeof(buf)); > igt_assert_eq(ret, -1); > + get_stream_status(stream_fd); > igt_assert_eq(errno, EINVAL); > > __perf_close(stream_fd); > @@ -2768,6 +2772,7 @@ test_disabled_read_error(void) > > ret = read(stream_fd, buf, sizeof(buf)); > igt_assert_eq(ret, -1); > + get_stream_status(stream_fd); > igt_assert_eq(errno, EINVAL); > > __perf_close(stream_fd); > @@ -2786,6 +2791,7 @@ test_disabled_read_error(void) > > ret = read(stream_fd, buf, sizeof(buf)); > igt_assert_eq(ret, -1); > + get_stream_status(stream_fd); > igt_assert_eq(errno, EINVAL); > > do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_ENABLE, 0); > -- > 2.43.0 >