From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E9B510E043 for ; Wed, 22 Mar 2023 05:32:02 +0000 (UTC) Date: Tue, 21 Mar 2023 22:31:59 -0700 Message-ID: <877cv9uzao.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230322000523.3310187-28-umesh.nerlige.ramappa@intel.com> References: <20230322000523.3310187-1-umesh.nerlige.ramappa@intel.com> <20230322000523.3310187-28-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t v4 27/31] lib/i915/perf: Update MTL OA timestamp and EU thread config List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Lionel G Landwerlin Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, 21 Mar 2023 17:05:19 -0700, Umesh Nerlige Ramappa wrote: > > MTL has configuration similar to DG2 for OA timestamp and threads per > EU. Update the same for MTL. > > Signed-off-by: Umesh Nerlige Ramappa > --- > lib/i915/perf.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/i915/perf.c b/lib/i915/perf.c > index d8624dc0..24ef3819 100644 > --- a/lib/i915/perf.c > +++ b/lib/i915/perf.c > @@ -432,6 +432,14 @@ intel_perf_for_devinfo(uint32_t device_id, > else > return unsupported_i915_perf_platform(perf); > } else if (devinfo->is_meteorlake) { > + perf->devinfo.eu_threads_count = 8; > + /* OA reports have the timestamp value shifted to the > + * right by 1 bits, it also means we cannot use the > + * top bit for comparison. > + */ > + perf->devinfo.oa_timestamp_shift = -1; > + perf->devinfo.oa_timestamp_mask = 0x7fffffff; > + Is it possible to add a Bspec reference for this? Otherwise: Reviewed-by: Ashutosh Dixit