From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8FFDD10E849
 for <igt-dev@lists.freedesktop.org>; Wed, 23 Feb 2022 16:39:37 +0000 (UTC)
Date: Wed, 23 Feb 2022 08:31:33 -0800
Message-ID: <877d9lbl3u.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Gupta, Anshuman" <anshuman.gupta@intel.com>
In-Reply-To: <49cdc125fb044f48ba65be1c36b07af3@intel.com>
References: <20220223095951.12430-1-anshuman.gupta@intel.com>
 <87tucp60ea.wl-ashutosh.dixit@intel.com>
 <49cdc125fb044f48ba65be1c36b07af3@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] i915_pm_rpm: Use __igt_debugfs_dump for
 i915_runtime_pm_status
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>, "Latvala,
 Petri" <petri.latvala@intel.com>, "Nilawar, Badal" <badal.nilawar@intel.com>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 23 Feb 2022 08:08:38 -0800, Gupta, Anshuman wrote:
>
>
>
> > -----Original Message-----
> > From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> > Sent: Wednesday, February 23, 2022 9:28 PM
> > To: Gupta, Anshuman <anshuman.gupta@intel.com>
> > Cc: igt-dev@lists.freedesktop.org; Ewins, Jon <jon.ewins@intel.com>; Latvala,
> > Petri <petri.latvala@intel.com>; Nilawar, Badal <badal.nilawar@intel.com>
> > Subject: Re: [PATCH i-g-t] i915_pm_rpm: Use __igt_debugfs_dump for
> > i915_runtime_pm_status
> >
> > On Wed, 23 Feb 2022 01:59:51 -0800, Anshuman Gupta wrote:
> > >
> > > Use __igt_debugfs_dump() in wait_for_suspended() in order to specify
> > > explicit igt log level.
> > > We need to dump the i915_runtime_pm_status even in case of igt test's
> > > skips as well, that requires log level to be IGT_LOG_INFO.
> >
> > Ok, by skip I believe you are referring to this:
> >
> >	igt_require(setup_environment(false));
>
> Yes, skips while setting up the environment.
> Thanks for RB, is it conditional to make commit log more verbose about
> IGT skips during setup_envirnment() ?

Hmm now that you mention it, maybe a comment above __igt_debugfs_dump()
saying something like "Dump status even if the test skips" will be
helpful. E.g. I didn't know that you need IGT_LOG_INFO for skips. Thanks.

> Thanks,
> Anshuman.
> >
> > Therefore:
> >
> > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> >
> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > > ---
> > >  tests/i915/i915_pm_rpm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index
> > > 6c8ffbd5d..eb4c4f4e3 100644
> > > --- a/tests/i915/i915_pm_rpm.c
> > > +++ b/tests/i915/i915_pm_rpm.c
> > > @@ -207,7 +207,7 @@ static bool wait_for_suspended(void)
> > >		bool suspended =
> > >igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
> > >
> > >		if (!suspended)
> > > -			igt_debugfs_dump(drm_fd,
> > "i915_runtime_pm_status");
> > > +			__igt_debugfs_dump(drm_fd,
> > "i915_runtime_pm_status",
> > > +IGT_LOG_INFO);
> > >
> > >		return suspended;
> > >	}
> > > --
> > > 2.26.2
> > >