Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 3/7] tests/gem_exec_alignment: Add prerequisite alignment condition
Date: Wed, 13 Oct 2021 21:12:36 -0700	[thread overview]
Message-ID: <877degi6rv.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211008065432.15482-4-zbigniew.kempczynski@intel.com>

On Thu, 07 Oct 2021 23:54:28 -0700, Zbigniew Kempczyński wrote:
>
> Skip the test if the kernel doesn't support passing object alignment.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  tests/i915/gem_exec_alignment.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/i915/gem_exec_alignment.c b/tests/i915/gem_exec_alignment.c
> index c4611bd1e..f40b391c9 100644
> --- a/tests/i915/gem_exec_alignment.c
> +++ b/tests/i915/gem_exec_alignment.c
> @@ -530,6 +530,7 @@ igt_main
>	igt_fixture {
>		fd = drm_open_driver(DRIVER_INTEL);
>		igt_require_gem(fd);
> +		igt_require(gem_allows_passing_alignment(fd));

How about renaming this function something like gem_allows_obj_alignment?
Otherwise this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

  reply	other threads:[~2021-10-14  4:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  6:54 [igt-dev] [PATCH i-g-t 0/7] Prepare IGTs to allow only zero alignment Zbigniew Kempczyński
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 1/7] lib/gem_submission: Add kernel exec object alignment capability Zbigniew Kempczyński
2021-10-13  4:47   ` Dixit, Ashutosh
2021-10-13  5:27     ` Zbigniew Kempczyński
2021-10-14  2:26       ` Dixit, Ashutosh
2021-10-14  7:14         ` Zbigniew Kempczyński
2021-10-14  7:22           ` Dixit, Ashutosh
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 2/7] lib/intel_batchbuffer: Detect and use kernel " Zbigniew Kempczyński
2021-10-14  2:37   ` Dixit, Ashutosh
2021-10-14  7:25     ` Zbigniew Kempczyński
2021-10-14  7:22       ` Dixit, Ashutosh
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 3/7] tests/gem_exec_alignment: Add prerequisite alignment condition Zbigniew Kempczyński
2021-10-14  4:12   ` Dixit, Ashutosh [this message]
2021-10-14  7:27     ` Zbigniew Kempczyński
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 4/7] tests/gem_evict_alignment: Skip if kernel doesn't support passing alignment Zbigniew Kempczyński
2021-10-14  4:14   ` Dixit, Ashutosh
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 5/7] tests/i915_pm_rpm: Fix invalid alignment Zbigniew Kempczyński
2021-10-14  4:18   ` Dixit, Ashutosh
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 6/7] benchmarks/gem_exec_fault: Add timeout argument Zbigniew Kempczyński
2021-10-14  4:24   ` Dixit, Ashutosh
2021-10-14  7:47     ` Zbigniew Kempczyński
2021-10-14  7:30       ` Dixit, Ashutosh
2021-10-08  6:54 ` [igt-dev] [PATCH i-g-t 7/7] benchmarks/gem_exec_fault: Add softpin mode to support gens with ppgtt Zbigniew Kempczyński
2021-10-14  5:01   ` Dixit, Ashutosh
2021-10-14  5:06     ` Dixit, Ashutosh
2021-10-14  8:11     ` Zbigniew Kempczyński
2021-10-08  7:48 ` [igt-dev] ✓ Fi.CI.BAT: success for Prepare IGTs to allow only zero alignment Patchwork
2021-10-08  9:02 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-10-14  8:19 [igt-dev] [PATCH i-g-t 0/7] " Zbigniew Kempczyński
2021-10-14  8:19 ` [igt-dev] [PATCH i-g-t 3/7] tests/gem_exec_alignment: Add prerequisite alignment condition Zbigniew Kempczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877degi6rv.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox