From: Jani Nikula <jani.nikula@intel.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Adapt to device-based DRM logging changes
Date: Tue, 02 Jun 2020 13:52:12 +0300 [thread overview]
Message-ID: <877dwp210j.fsf@intel.com> (raw)
In-Reply-To: <20200602101916.30459-1-petri.latvala@intel.com>
On Tue, 02 Jun 2020, Petri Latvala <petri.latvala@intel.com> wrote:
> DRM logging in the kernel has switched to device based logging,
> changing the pattern of logging from
>
> [drm:function_name] Message
>
> to
>
> i915 0000:00:02.0: [drm] Message
>
> Change the pattern we use with --piglit-style-dmesg to match the new
> style logging, catching all warnings that contain [drm]. We're no
> longer result-wise exactly piglit compatible but then again that ship
> sailed long time ago with the change of introducing dmesg-level
> parameter. Piglit compatibility result-wise is not a goal regardless.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
>
> For the record: This won't be merged without making sure cibuglog
> filtering is up to date.
>
> runner/resultgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 17147a8f..add4aad5 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -808,7 +808,7 @@ static const char igt_dmesg_whitelist[] =
> #undef _
>
> static const char igt_piglit_style_dmesg_blacklist[] =
> - "(\\[drm:|drm_|intel_|i915_)";
> + "(\\[drm:|drm_|intel_|i915_|\\[drm\\])";
>
> static bool init_regex_whitelist(struct settings* settings, GRegex **re)
> {
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-06-02 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 10:19 [igt-dev] [PATCH i-g-t] runner: Adapt to device-based DRM logging changes Petri Latvala
2020-06-02 10:52 ` Jani Nikula [this message]
2020-06-02 11:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-06-02 13:12 ` Patchwork
2020-06-02 13:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-06-02 17:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-06-03 6:42 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dwp210j.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox