From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C58B6E2D6 for ; Sat, 1 Feb 2020 05:42:52 +0000 (UTC) Date: Fri, 31 Jan 2020 21:42:50 -0800 Message-ID: <877e166exx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200131173109.12527-2-ramalingam.c@intel.com> References: <20200131173109.12527-1-ramalingam.c@intel.com> <20200131173109.12527-2-ramalingam.c@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ramalingam C Cc: igt-dev List-ID: On Fri, 31 Jan 2020 09:31:01 -0800, Ramalingam C wrote: > > In the absence of the mappable aperture, skip GTT and > fence specific tests. > > v2: > requirement check is moved to subtest start [Zbigniew] > > Signed-off-by: Ramalingam C > --- > tests/prime_vgem.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c > index 3bdb23007d56..c483cbe722ea 100644 > --- a/tests/prime_vgem.c > +++ b/tests/prime_vgem.c > @@ -846,14 +846,18 @@ igt_main > igt_subtest("basic-write") > test_write(vgem, i915); > > - igt_subtest("basic-gtt") > + igt_subtest("basic-gtt") { > + gem_require_mappable_ggtt(i915); > test_gtt(vgem, i915); > + } To me seems no reason to skip this. We could either unconditionally use device_coherent() or use mmap_gtt() if gtt is available else device_coherent()? Though probably the test would need to be renamed as test_device_coherent()? > > igt_subtest("shrink") > test_shrink(vgem, i915); > > - igt_subtest("coherency-gtt") > + igt_subtest("coherency-gtt") { > + gem_require_mappable_ggtt(i915); > test_gtt_interleaved(vgem, i915); > + } Probably similar situation here, though with WC instead of GTT the test should always pass? > > for (e = intel_execution_engines; e->name; e++) { > igt_subtest_f("%ssync-%s", > @@ -902,8 +906,10 @@ igt_main > > igt_subtest("basic-fence-read") > test_fence_read(i915, vgem); > - igt_subtest("basic-fence-mmap") > + igt_subtest("basic-fence-mmap") { > + gem_require_mappable_ggtt(i915); > test_fence_mmap(i915, vgem); > + } Once again, just use device_coherent()? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev