From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BBC1FF8861 for ; Mon, 27 Apr 2026 06:49:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A51D710E1E6; Mon, 27 Apr 2026 06:49:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jM8M3Ubz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC86710E1E6 for ; Mon, 27 Apr 2026 06:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777272549; x=1808808549; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Ur9aSYaV72CMBrgzkzwDZNyIPgLGTvT39mEHBihxlEU=; b=jM8M3Ubz02bw0hkXgekW4gGNsD88HJk0TLSY79kqk15J5ozL6DGfPlOh hYva/9SGAePzyDerV3sHwbUNazq8iQrsHErSz1rt8x5JXAAkNtMNmX1ag x4TUARLX2RvRQv3Vs/CWa4CLPHSsLNUg88TIgvCB1v+yTsEyvVayxkE2i odZCRVgy+00mCliWUMBFDrlDjL0ELJz0oPRj8+t3hKZln5iQyEwbuPB1s Sv0rNW8Wy3Im73kIPXnH5OEIsN5Z9TydEZ/MIT2cw9imG1wc/pP65Wpec 7Q9gCPqos01xlFQLj3RdtToEadESTEUYD7oZsu+hbYutkqE1dmvJTzL2u Q==; X-CSE-ConnectionGUID: beOhDN4ORqCXj1wVQ1Lzng== X-CSE-MsgGUID: o0/h3eKEReqFzmKwHdehDw== X-IronPort-AV: E=McAfee;i="6800,10657,11768"; a="77857520" X-IronPort-AV: E=Sophos;i="6.23,201,1770624000"; d="scan'208";a="77857520" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2026 23:49:09 -0700 X-CSE-ConnectionGUID: Y+yuak0yTgSvjhLf6fFbPQ== X-CSE-MsgGUID: eN62rKFORhS17pcAlw05Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,201,1770624000"; d="scan'208";a="256857060" Received: from rabedin-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.32.92]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2026 23:49:08 -0700 Date: Sun, 26 Apr 2026 23:49:07 -0700 Message-ID: <878qa85258.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <20260427050002.3391994-1-shekhar.chauhan@intel.com> References: <20260427050002.3391994-1-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Sun, 26 Apr 2026 22:00:02 -0700, Shekhar Chauhan wrote: > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > device mem access, OA exponent values lower than 8 can result in buffer > overflows. Bump the OA exponent value. > > v2: Fix commit title, description and code description. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..cbc1e0d3e 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -2645,6 +2645,16 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > { > /* ~20 micro second period */ > int oa_exponent = max_oa_exponent_for_period_lte(20000); > + > + /* > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > + * Because of slower device mem access, OA exponent values lower than 8 can > + * result in buffer overflows. > + */ > + This extra newline shouldn't be there. Anyway, I'll fix it up while merging. Otherwise LGTM: Reviewed-by: Ashutosh Dixit > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && IS_CRESCENTISLAND(devid)) > + oa_exponent = max(oa_exponent, 8); > + > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > uint64_t fmt = test_set->perf_oa_format; > size_t report_size = get_oa_format(fmt).size; > -- > 2.53.0 >