From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 273C26E50D for ; Thu, 16 Aug 2018 20:31:52 +0000 (UTC) Received: by mail-io0-x244.google.com with SMTP id z20-v6so4997210iol.0 for ; Thu, 16 Aug 2018 13:31:52 -0700 (PDT) Message-ID: <879e02b96ca26cf8ae83278800a482c691866a6a.camel@gmail.com> From: Dhinakaran Pandiyan Date: Thu, 16 Aug 2018 13:31:34 -0700 In-Reply-To: <077713ce-c136-814d-2220-592916b8374b@linux.intel.com> References: <20180814122222.31509-1-maarten.lankhorst@linux.intel.com> <0b5c8f91d89913bd7281fdd8ef94a64a607a9de4.camel@intel.com> <077713ce-c136-814d-2220-592916b8374b@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/psr: Add support for toggling edp psr through debugfs, v4. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCAyMDE4LTA4LTE2IGF0IDEzOjQxICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBPcCAxNi0wOC0xOCBvbSAwMjoyNiBzY2hyZWVmIERoaW5ha2FyYW4gUGFuZGl5YW46Cj4g PiBPbiBUdWUsIDIwMTgtMDgtMTQgYXQgMTQ6MjIgKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdy b3RlOgo+ID4gPiBJdCdzIGhhcm1mdWwgdG8gd3JpdGUgdG8gZW5hYmxlX3BzciBhdCBydW50aW1l LCBhbmQgdGhlIHBhdGNoCj4gPiA+IHRoYXQKPiA+ID4gYWxsb3dzCj4gPiA+IHVzIHRvIGNoYW5n ZSBpOTE1X2VkcF9wc3JfZGVidWcgd2l0aCB0aGUgcGFuZWwgcnVubmluZyB3aWxsCj4gPiA+IHJl cXVpcmUKPiA+ID4gdXMKPiA+ID4gdG8gYWJhbmRvbiB0aGUgbW9kdWxlIHBhcmFtZXRlci4gSGVu Y2UgdGhlIHVzZXJzcGFjZSBjaGFuZ2UgbmVlZHMKPiA+ID4gdG8KPiA+ID4gYmUKPiA+ID4gcHV0 IGluIElHVCBmaXJzdCBiZWZvcmUgd2UgY2FuIGNoYW5nZSBpdCBhdCBrZXJuZWwgdGltZS4KPiA+ ID4gCj4gPiA+IFRvZ2dsaW5nIGl0IHRvIGRlYnVnZnMgd2lsbCBtZWFuIHdlIGNhbiBza2lwIGEg bW9kZXNldCB3aGVuCj4gPiA+IGNoYW5naW5nCj4gPiA+IG91cgo+ID4gPiBmZWF0dXJlIHNldC4K PiA+ID4gCj4gPiA+IENoYW5nZXMgc2luY2UgdjE6Cj4gPiA+IC0gUmViYXNlIHdpdGggdGhlIHBy ZXZpb3VzIHBhdGNoZXMgZHJvcHBlZC4KPiA+ID4gQ2hhbmdlcyBzaW5jZSB2MjoKPiA+ID4gLSBS ZWJhc2Ugb24gdG9wIG9mIG5ldyBhcGkgaW4gaTkxNV9lZHBfcHNyX2RlYnVnLgo+ID4gPiBDaGFu Z2VzIHNpbmNlIHYzOgo+ID4gPiAtIEVuYWJsZSBJUlEgZGVidWdnaW5nIGZvciBleHRyYSBsb2dn aW5nLgo+ID4gPiAtIEZvcmNlIFBTUjEgbW9kZS4gKGRobmtybikKPiA+ID4gLSBNb3ZlIFBTUiBl bmFibGUvZGlzYWJsZSBmdW5jdGlvbnMgdG8gbGliL2lndF9wc3IuIChkaG5rcm4pCj4gPiA+IAo+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuYwo+ID4gPiBvbT4KPiA+ID4gLS0tCj4gPiA+ICBsaWIvaWd0X3Bzci5jICAg ICAgICAgICAgICAgICAgICB8IDkwCj4gPiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KystCj4gPiA+ICBsaWIvaWd0X3Bzci5oICAgICAgICAgICAgICAgICAgICB8ICAyICsKPiA+ID4g IHRlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jIHwgIDYgKy0tCj4gPiA+ICAzIGZpbGVz IGNoYW5nZWQsIDkzIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBk aWZmIC0tZ2l0IGEvbGliL2lndF9wc3IuYyBiL2xpYi9pZ3RfcHNyLmMKPiA+ID4gaW5kZXggYzk3 OWIwYjU5OTM2Li4zOTM3MDIwMzc4NjEgMTAwNjQ0Cj4gPiA+IC0tLSBhL2xpYi9pZ3RfcHNyLmMK PiA+ID4gKysrIGIvbGliL2lndF9wc3IuYwo+ID4gPiBAQCAtMjEsNyArMjEsOSBAQAo+ID4gPiAg ICogSU4gVEhFIFNPRlRXQVJFLgo+ID4gPiAgICovCj4gPiA+ICAKPiA+ID4gLSNpbmNsdWRlICAi aWd0X3Bzci5oIgo+ID4gPiArI2luY2x1ZGUgImlndF9wc3IuaCIKPiA+ID4gKyNpbmNsdWRlICJp Z3Rfc3lzZnMuaCIKPiA+ID4gKyNpbmNsdWRlIDxlcnJuby5oPgo+ID4gPiAgCj4gPiA+ICBib29s IHBzcl9hY3RpdmUoaW50IGZkLCBib29sIGNoZWNrX2FjdGl2ZSkKPiA+ID4gIHsKPiA+ID4gQEAg LTM4LDMgKzQwLDg5IEBAIGJvb2wgcHNyX3dhaXRfZW50cnkoaW50IGZkKQo+ID4gPiAgewo+ID4g PiAgCXJldHVybiBpZ3Rfd2FpdChwc3JfYWN0aXZlKGZkLCB0cnVlKSwgNTAwLCAxKTsKPiA+ID4g IH0KPiA+ID4gKwo+ID4gPiArc3RhdGljIHNzaXplX3QgcHNyX3dyaXRlKGludCBmZCwgY29uc3Qg Y2hhciAqYnVmKQo+ID4gPiArewo+ID4gPiArCXJldHVybiBpZ3Rfc3lzZnNfd3JpdGUoZmQsICJp OTE1X2VkcF9wc3JfZGVidWciLCBidWYsCj4gPiA+IHN0cmxlbihidWYpKTsKPiA+ID4gK30KPiA+ ID4gKwo+ID4gPiArc3RhdGljIGludCBoYXNfcHNyX2RlYnVnZnMoaW50IGZkKQo+ID4gPiArewo+ ID4gPiArCWludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKwkvKgo+ID4gPiArCSAqIENoZWNrIGlmIG5l dyBQU1IgZGVidWdmcyBhcGkgaXMgdXNhYmxlIGJ5IHdyaXRpbmcgYW4KPiA+ID4gaW52YWxpZCB2 YWx1ZS4KPiA+ID4gKwkgKiBMZWdhY3kgbW9kZSB3aWxsIHJldHVybiBPSyBoZXJlLCBkZWJ1Z2Zz IGFwaSB3aWxsCj4gPiA+IHJldHVybgo+ID4gPiAtRUlOVkFMLgo+ID4gPiArCSAqIC1FTk9ERVYg aXMgcmV0dXJuZWQuCj4gPiA+ICsJICovCj4gPiA+ICsJcmV0ID0gcHNyX3dyaXRlKGZkLCAiMHhm Iik7Cj4gPiA+ICsJaWYgKHJldCA9PSAtRUlOVkFMKQo+ID4gPiArCQlyZXR1cm4gMDsKPiA+ID4g KwllbHNlIGlmIChyZXQgPj0gMCkKPiA+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAKPiA+IFdl IHNob3VsZCBkaXNhYmxlIGRlYnVnIGhlcmUsIFBTUiBpbnRlcnJ1cHRzIGFyZW4ndCB1c2VkIGlu IElHVHMuCj4gPiBMb29rcwo+ID4gIGxpa2UgeW91IHNlbnQgdGhpcyBwYXRjaCBiZWZvcmUgSSBy ZXNwb25kZWQgdG8geW91ciBxdWVzdGlvbiBhYm91dAo+ID4gaW50ZXJydXB0cy4KPiA+IAo+ID4g Cj4gPiA+ICsJZWxzZQo+ID4gPiArCQlyZXR1cm4gcmV0Owo+ID4gPiArfQo+ID4gPiArCj4gPiA+ ICtzdGF0aWMgYm9vbCBwc3JfbW9kcGFyYW1fc2V0KGludCB2YWwpCj4gPiA+ICt7Cj4gPiA+ICsJ c3RhdGljIGludCBvbGR2YWwgPSAtMTsKPiA+ID4gKwo+ID4gPiArCWlndF9zZXRfbW9kdWxlX3Bh cmFtX2ludCgiZW5hYmxlX3BzciIsIHZhbCk7Cj4gPiA+ICsKPiA+ID4gKwlpZiAodmFsID09IG9s ZHZhbCkKPiA+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gPiArCj4gPiA+ICsJb2xkdmFsID0gdmFs Owo+ID4gPiArCXJldHVybiB0cnVlOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICtzdGF0aWMgaW50 IHBzcl9yZXN0b3JlX2RlYnVnZnNfZmQgPSAtMTsKPiA+ID4gKwo+ID4gPiArc3RhdGljIHZvaWQg cmVzdG9yZV9wc3JfZGVidWdmcyhpbnQgc2lnKQo+ID4gPiArewo+ID4gPiArCXBzcl93cml0ZShw c3JfcmVzdG9yZV9kZWJ1Z2ZzX2ZkLCAiMCIpOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICtzdGF0 aWMgYm9vbCBwc3Jfc2V0KGludCBmZCwgYm9vbCBlbmFibGUpCj4gPiA+ICt7Cj4gPiA+ICsJaW50 IHJldDsKPiA+ID4gKwo+ID4gPiArCWlndF9za2lwX29uX2YoZmQgPCAwLCAiQ291bGQgbm90IG9w ZW4gZGVidWdmcyBkaXJcbiIpOwo+ID4gPiArCj4gPiA+ICsJcmV0ID0gaGFzX3Bzcl9kZWJ1Z2Zz KGZkKTsKPiA+ID4gKwlpZiAocmV0ID09IC1FTk9ERVYpIHsKPiA+ID4gKwkJaWd0X3NraXBfb25f ZihlbmFibGUsICJQU1Igbm90IGF2YWlsYWJsZVxuIik7Cj4gPiA+ICsJCXJldHVybiBmYWxzZTsK PiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwkvKgo+ID4gPiArCSAqIFJlc3RvcmUgb3JpZ2luYWwg ZGVidWdmcyB2YWx1ZSBvbiBleGl0LCBldmVuIGZvcgo+ID4gPiArCSAqIGxlZ2FjeSBjYXNlLCBi ZWNhdXNlIHdyaXRpbmcgMHhmIHdpbGwgc2V0IHRoZSBkZWJ1Zwo+ID4gPiBmbGFnCj4gPiA+ICsJ ICogcmVnYXJkbGVzcy4KPiA+ID4gKwkgKi8KPiA+ID4gKwlpZiAocHNyX3Jlc3RvcmVfZGVidWdm c19mZCA9PSAtMSkgewo+ID4gPiArCQlwc3JfcmVzdG9yZV9kZWJ1Z2ZzX2ZkID0gZHVwKGZkKTsK PiA+ID4gKwkJaWd0X2Fzc2VydChwc3JfcmVzdG9yZV9kZWJ1Z2ZzX2ZkID49IDApOwo+ID4gPiAr CQlpZ3RfaW5zdGFsbF9leGl0X2hhbmRsZXIocmVzdG9yZV9wc3JfZGVidWdmcyk7Cj4gPiA+ICsJ fQo+ID4gPiArCj4gPiA+ICsJaWYgKHJldCA9PSAtRUlOVkFMKSB7Cj4gPiA+ICsJCXJldCA9IHBz cl9tb2RwYXJhbV9zZXQoZW5hYmxlKTsKPiA+ID4gKwl9IGVsc2Ugewo+ID4gPiArCQlyZXQgPSBw c3Jfd3JpdGUoZmQsIGVuYWJsZSA/ICIweDEzIiA6ICIxIik7Cj4gPiAKPiA+ICIweDMiIHRvIGF2 b2lkIGVuYWJsaW5nIGludGVycnVwdHMuCj4gPiAKPiA+IEFuZCBhbSBub3QgcXVpdGUgc3VyZSBo b3cgdGhpcyByZXR1cm4gdHJhbnNsYXRlcyB0byBuZWVkX21vZGVzZXQgaW4KPiA+IHRoZQo+ID4g bmV4dCBwYXRjaC4gV2h5IGlzIGEgbW9kZXNldCBuZWVkZWQgaWYgcHNyX3dyaXRlKCkgc3VjY2Vz c2Z1bGx5Cj4gPiB3cm90ZQo+ID4gYWxsIHRoZSBieXRlcz8KPiAKPiBPb3BzLCBzaG91bGQgcmVz ZXQgdG8gZmFsc2UgaW4gdGhhdCBjYXNlLgo+IAo+IEFueSBvdGhlciBjb21tZW50cyBvbiB0aGUg c2VyaWVzIG9yIGlzIGl0IGdvb2Qgd2l0aCB0aG9zZSAyIGZpeGVzPwoKSSBuZWVkIGEgYml0IG1v cmUgdGltZSB0byByZXZpZXcgcGF0Y2ggMi8yLCBub3QgdmVyeSBmYW1pbGlhciB3aXRoIHRoZQpm bG93IGluIGZyb250YnVmZmVyX3RyYWNraW5nLmMKCgo+IAo+IH5NYWFydGVuCj4gPiA+ICsJCWln dF9hc3NlcnQocmV0ID4gMCk7Cj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ICsJcmV0dXJuIHJldDsK PiA+ID4gK30KPiA+ID4gKwo+ID4gPiArYm9vbCBwc3JfZW5hYmxlKGludCBmZCkKPiA+ID4gK3sK PiA+ID4gKwlyZXR1cm4gcHNyX3NldChmZCwgdHJ1ZSk7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4g K2Jvb2wgcHNyX2Rpc2FibGUoaW50IGZkKQo+ID4gPiArewo+ID4gPiArCXJldHVybiBwc3Jfc2V0 KGZkLCBmYWxzZSk7Cj4gPiA+ICt9Cj4gPiA+IGRpZmYgLS1naXQgYS9saWIvaWd0X3Bzci5oIGIv bGliL2lndF9wc3IuaAo+ID4gPiBpbmRleCA5ODBmODVlMDRiM2UuLjBlZjIyYzNkMTI1OCAxMDA2 NDQKPiA+ID4gLS0tIGEvbGliL2lndF9wc3IuaAo+ID4gPiArKysgYi9saWIvaWd0X3Bzci5oCj4g PiA+IEBAIC0zMCw1ICszMCw3IEBACj4gPiA+ICAKPiA+ID4gIGJvb2wgcHNyX3dhaXRfZW50cnko aW50IGZkKTsKPiA+ID4gIGJvb2wgcHNyX2FjdGl2ZShpbnQgZmQsIGJvb2wgY2hlY2tfYWN0aXZl KTsKPiA+ID4gK2Jvb2wgcHNyX2VuYWJsZShpbnQgZmQpOwo+ID4gPiArYm9vbCBwc3JfZGlzYWJs ZShpbnQgZmQpOwo+ID4gPiAgCj4gPiA+ICAjZW5kaWYKPiA+ID4gZGlmZiAtLWdpdCBhL3Rlc3Rz L2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jCj4gPiA+IGIvdGVzdHMva21zX2Zyb250YnVmZmVy X3RyYWNraW5nLmMKPiA+ID4gaW5kZXggMWRmZDdjMWNlZThkLi43ZWEyZjY5NzE4NGQgMTAwNjQ0 Cj4gPiA+IC0tLSBhL3Rlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jCj4gPiA+ICsrKyBi L3Rlc3RzL2ttc19mcm9udGJ1ZmZlcl90cmFja2luZy5jCj4gPiA+IEBAIC05NDEsOCArOTQxLDYg QEAgc3RhdGljIGJvb2wKPiA+ID4gZHJyc193YWl0X3VudGlsX3JyX3N3aXRjaF90b19sb3codm9p ZCkKPiA+ID4gIAo+ID4gPiAgI2RlZmluZSBmYmNfZW5hYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFy YW1faW50KCJlbmFibGVfZmJjIiwgMSkKPiA+ID4gICNkZWZpbmUgZmJjX2Rpc2FibGUoKSBpZ3Rf c2V0X21vZHVsZV9wYXJhbV9pbnQoImVuYWJsZV9mYmMiLCAwKQo+ID4gPiAtI2RlZmluZSBwc3Jf ZW5hYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfcHNyIiwgMSkKPiA+ID4g LSNkZWZpbmUgcHNyX2Rpc2FibGUoKSBpZ3Rfc2V0X21vZHVsZV9wYXJhbV9pbnQoImVuYWJsZV9w c3IiLCAwKQo+ID4gPiAgI2RlZmluZSBkcnJzX2VuYWJsZSgpCWRycnNfc2V0KDEpCj4gPiA+ICAj ZGVmaW5lIGRycnNfZGlzYWJsZSgpCWRycnNfc2V0KDApCj4gPiA+ICAKPiA+ID4gQEAgLTExMzcs NyArMTEzNSw3IEBAIHN0YXRpYyB2b2lkIGRpc2FibGVfZmVhdHVyZXMoY29uc3Qgc3RydWN0Cj4g PiA+IHRlc3RfbW9kZSAqdCkKPiA+ID4gIAkJcmV0dXJuOwo+ID4gPiAgCj4gPiA+ICAJZmJjX2Rp c2FibGUoKTsKPiA+ID4gLQlwc3JfZGlzYWJsZSgpOwo+ID4gPiArCXBzcl9kaXNhYmxlKGRybS5k ZWJ1Z2ZzKTsKPiA+ID4gIAlkcnJzX2Rpc2FibGUoKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiBA QCAtMTcxOSw3ICsxNzE3LDcgQEAgc3RhdGljIHZvaWQgZW5hYmxlX2ZlYXR1cmVzX2Zvcl90ZXN0 KGNvbnN0Cj4gPiA+IHN0cnVjdCB0ZXN0X21vZGUgKnQpCj4gPiA+ICAJaWYgKHQtPmZlYXR1cmUg JiBGRUFUVVJFX0ZCQykKPiA+ID4gIAkJZmJjX2VuYWJsZSgpOwo+ID4gPiAgCWlmICh0LT5mZWF0 dXJlICYgRkVBVFVSRV9QU1IpCj4gPiA+IC0JCXBzcl9lbmFibGUoKTsKPiA+ID4gKwkJcHNyX2Vu YWJsZShkcm0uZGVidWdmcyk7Cj4gPiA+ICAJaWYgKHQtPmZlYXR1cmUgJiBGRUFUVVJFX0RSUlMp Cj4gPiA+ICAJCWRycnNfZW5hYmxlKCk7Cj4gPiA+ICB9Cj4gCj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+ IGlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Ci0tIAotREsKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRl dkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==