From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01A85C35FFC for ; Thu, 20 Mar 2025 01:14:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FCBC10E111; Thu, 20 Mar 2025 01:14:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mYQQdyOq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBFE910E111 for ; Thu, 20 Mar 2025 01:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742433248; x=1773969248; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=MYi9ZGwGU/gSZeW4uJSPvDEt/BwLY0M9eoRll7I6hX0=; b=mYQQdyOqJU9ZgfYk5rp16wjAkcaNMtbJn0XXr7Z2priMSYKqtgX0NF14 fVdHazHMrpyuKgDSojgVM5gEhLbeUoKtRTApSwdgm4Kt0F67YsTKumT3n tqCNMTWiambinZAAr6PutOkWmqGPY8/025RGbQirPYlMVeEI42zN94bQ/ rXrBnE5BcuoGOtBSAs7UC0bjpoGbjvYr9LMgPWGdkpL5Qcku9tgXrKeLw DZrzni9bm0Onlmr9Cc+9EOGP5yDajp35RoUiHllQrIbBKifmoiKx/wnC9 yFteYDh96Ce/7V0OvlgufaN+zQtonir0oGj9sFmvUypfmW2MroVKgZMsj Q==; X-CSE-ConnectionGUID: kAeZdO+YQqGeS8bQjDe7/w== X-CSE-MsgGUID: /EvxCUszSxaQ6RnS24eeCw== X-IronPort-AV: E=McAfee;i="6700,10204,11378"; a="61040533" X-IronPort-AV: E=Sophos;i="6.14,260,1736841600"; d="scan'208";a="61040533" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2025 18:14:07 -0700 X-CSE-ConnectionGUID: X5v1A5vRTDCX1RQBE2myUA== X-CSE-MsgGUID: uSeVR9/BSgmqA4/PJiBbUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,260,1736841600"; d="scan'208";a="127708827" Received: from bjkilduf-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.114.153]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2025 18:14:08 -0700 Date: Wed, 19 Mar 2025 18:14:06 -0700 Message-ID: <87a59g33mp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Oak Zeng Cc: , , , Subject: Re: [i-g-t v7 4/4] tests/intel/xe_vm: Allow scratch page under fault mode on LNL and BMG In-Reply-To: <20250319224231.1909393-5-oak.zeng@intel.com> References: <20250319224231.1909393-1-oak.zeng@intel.com> <20250319224231.1909393-5-oak.zeng@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 19 Mar 2025 15:42:31 -0700, Oak Zeng wrote: > > Due to a fix of out of bound prefetch issue, we now allow scratch > page coexist with fault mode on LNL and BMG. Modify invalid_flag > test to reflect this change. > > v1: make the change in invalid_flag (vs caller) (Ashutosh) > > Signed-off-by: Oak Zeng > --- > tests/intel/xe_vm.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c > index fdf74c114..928baf0de 100644 > --- a/tests/intel/xe_vm.c > +++ b/tests/intel/xe_vm.c > @@ -2259,10 +2259,17 @@ static void bind_flag_invalid(int fd) > > static void invalid_flag(int fd, __u32 flags) > { > + uint16_t dev_id = intel_get_drm_devid(fd); > struct drm_xe_vm_create create = { > .flags = flags, > }; > > + if (IS_LUNARLAKE(dev_id) || IS_BATTLEMAGE(dev_id)) { > + if ((flags & DRM_XE_VM_CREATE_FLAG_SCRATCH_PAGE) && > + (flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE)) > + return; > + } Reviewed-by: Ashutosh Dixit But note that the above code will show the test as successful, which may be ok. If you want to show the test as skipping instead, use igt_skip_on(). > + > do_ioctl_err(fd, DRM_IOCTL_XE_VM_CREATE, &create, EINVAL); > } > > -- > 2.26.3 >