From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EB7E10E053 for ; Sat, 7 Oct 2023 01:15:04 +0000 (UTC) Date: Fri, 06 Oct 2023 18:15:02 -0700 Message-ID: <87a5sv1be1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Kumar, Janga Rahul" In-Reply-To: References: <20231006051507.1945869-1-priyanka.dandamudi@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH] tests/xe/perf_pmu: Tests for the XE pmu interface List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "igt-dev@lists.freedesktop.org" , venkata.ramana.nayana@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 06 Oct 2023 02:31:19 -0700, Kumar, Janga Rahul wrote: > Hi Priyanka, > > From: Dandamudi, Priyanka > > Sent: Friday, October 6, 2023 10:45 AM > > To: Kumar, Janga Rahul ; igt- > > dev@lists.freedesktop.org; Dandamudi, Priyanka > > > > Subject: [PATCH] tests/xe/perf_pmu: Tests for the XE pmu interface > > > > From: Venkata Ramana Nayana > > > > There are set of engine group busyness counters provided by HW which are > > exposed via PMU events. Adding a basic unit tests to read those counters. > > > > v2: Added idle condition checks while reading the counters. (Rahul) > > > > v3: Moved test from tests/xe/ location to tests/intel. > > Modified code to work for xe_exec_queue_create xe_spin_init changes. > > > > Cc: Janga Rahul Kumar > > Signed-off-by: Venkata Ramana Nayana > > > > Signed-off-by: Priyanka Dandamudi > > Reviewed-by: Janga Rahul Kumar OK good that the original patch is reverted (though it should not have been merged in the first place) so at least it fixed part the drm_xe_exec_queue_get_property. However this patch is still incorrect because you should do a 'make headers_install' from the latest drm-xe-next kernel branch and then send /that/ patch. Ashutosh