From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D496E89BBE
 for <igt-dev@lists.freedesktop.org>; Mon,  6 Sep 2021 21:23:03 +0000 (UTC)
Date: Mon, 06 Sep 2021 14:23:02 -0700
Message-ID: <87a6kpl7pl.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <YTWzdjyUV49hy5/f@platvala-desk.ger.corp.intel.com>
References: <20210902173043.821318-1-alan.previn.teres.alexis@intel.com>
 <20210902173043.821318-2-alan.previn.teres.alexis@intel.com>
 <YTH5gdy/GGp1LT6C@platvala-desk.ger.corp.intel.com>
 <0ec0c1e9f6e06a7cdf9b87f377c892f542d10ece.camel@intel.com>
 <YTWzdjyUV49hy5/f@platvala-desk.ger.corp.intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v9 01/16] Add PXP UAPI support in
 i915_drm.h
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Petri Latvala <petri.latvala@intel.com>
Cc: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>, "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 05 Sep 2021 23:21:42 -0700, Petri Latvala wrote:
>
> On Sat, Sep 04, 2021 at 12:11:47AM +0300, Teres Alexis, Alan Previn wrote:
> > oops - my bad - didnt realize we had that - will do.
> >
> > While on this, would it make sense to permanently include
> > lib/i915/i915_drm_local.h from include/drm- uapi/i915_drm.h (but latter
> > would always remain empty on upstream)?. This way, when kernel support
> > is added for UAPI changes, we move the definitions across but dont add
> > and need remove the '#include "lib/i915/i915_drm_local.h" from the
> > other source files (requiring another change)?
>
> It would, but it's impossible. include/drm-uapi/i915_drm.h is supposed
> to be a pristine unchanged drop from the kernel.
>
> The other way around might work but looks more odd from the .c side.

But each source file does not have to include i915_drm_local.h since it is
included in igt_gt.h. So as long as igt_gt.h is included (which should be,
directly or indirectly) i915_drm_local.h is automatically included and does
not have to be explicitly included.