From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>,
Dixit@freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable
Date: Fri, 31 Jan 2020 19:38:49 -0800 [thread overview]
Message-ID: <87a7635646.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200131170416.7663-1-antonio.argenziano@intel.com>
On Fri, 31 Jan 2020 09:04:16 -0800, Antonio Argenziano wrote:
>
> The subtest tries to do a gtt mapping but if there is no mappable
> aperture that is not possible.
>
> v2:
> - Skip the whole dynamic subtest. (Petri)
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Though Chris did have comments on this so he may want to review/ack this
too. Thanks!
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/i915/gem_exec_basic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 70dce34b..b3c56369 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -141,6 +141,8 @@ igt_main
> }
>
> igt_subtest_with_dynamic("gtt") {
> + gem_require_mappable_ggtt(fd);
> +
> __for_each_physical_engine(fd, e) {
> igt_dynamic_f("%s", e->name)
> gtt(fd, e->flags);
> --
> 2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-01 3:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:04 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable Antonio Argenziano
2020-01-31 18:00 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable (rev3) Patchwork
2020-02-01 3:38 ` Dixit, Ashutosh [this message]
2020-02-04 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-01-31 0:15 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Skip subtest gtt if gtt mapping is unavailable Antonio Argenziano
2020-01-31 5:05 ` Dixit, Ashutosh
2020-01-31 8:20 ` Chris Wilson
2020-01-31 10:50 ` Petri Latvala
2020-01-31 10:56 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7635646.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=Dixit@freedesktop.org \
--cc=antonio.argenziano@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox