From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C482BCD343F for ; Thu, 7 May 2026 15:11:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75D6710F1A6; Thu, 7 May 2026 15:11:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BkcW7+69"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23FA310E599 for ; Thu, 7 May 2026 15:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778166681; x=1809702681; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jZzfAF3d3/9DNy9DNUOqJih37rxpDobVeVcpXPmMi1Q=; b=BkcW7+69dNXghBUsusf/iSNEJcjE36cMX7OuHpJfyHDqgckAVZIwce8N Z/nENnHgghcf/DitDqpOz1jSFLaZnBZ2W7tLPsKynVgRuYCT6kT2pa3uP Vi952gFkbofnYlZ4x2k0QkBo5+FiCAHyhMQE3pP5h/cNCx0xrMhmH4t46 z3a/j/8O6qkBtlcI7H9igYvGoYw+HiBpUUU75zgHJrQ1poyjp5jQOIyNS eem0CzlWKBDkebZvE7PWmJMjSzQMi979h50jN8LuhTTc9Fx0nBV90ZraM gtmLo+KxSu2RbNAlyphQIrNYbQsgPYD6Z1SnxIuTJOZhTmKnaQQ6/whWm Q==; X-CSE-ConnectionGUID: KemuEYs9QfCn+Jv9XNc4nA== X-CSE-MsgGUID: H/R1GprCSY+5JRDDRBxATg== X-IronPort-AV: E=McAfee;i="6800,10657,11779"; a="78839815" X-IronPort-AV: E=Sophos;i="6.23,221,1770624000"; d="scan'208";a="78839815" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2026 08:11:20 -0700 X-CSE-ConnectionGUID: QFA/dBZGRGKAUuvqySQF6w== X-CSE-MsgGUID: +rp4QuQiRUuDTLf1lJGSAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,221,1770624000"; d="scan'208";a="238287937" Received: from cbrown-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.134.206]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2026 08:11:20 -0700 Date: Thu, 07 May 2026 08:11:19 -0700 Message-ID: <87bjergsq0.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v6 2/2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <20260507053459.766300-3-shekhar.chauhan@intel.com> References: <20260507053459.766300-1-shekhar.chauhan@intel.com> <20260507053459.766300-3-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 06 May 2026 22:34:59 -0700, Shekhar Chauhan wrote: > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > device mem access, OA exponent values lower than 8 can result in buffer > overflows. Bump the OA exponent value. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..c464d5a0d 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -24,6 +24,7 @@ > #include "igt_device.h" > #include "igt_syncobj.h" > #include "igt_sysfs.h" > +#include "intel_wa.h" > #include "xe/xe_ioctl.h" > #include "xe/xe_query.h" > #include "xe/xe_oa.h" > @@ -2648,6 +2649,11 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > uint64_t fmt = test_set->perf_oa_format; > size_t report_size = get_oa_format(fmt).size; > + /* > + * If modifying the indices or order of items inside properties[], > + * ensure that a corresponding change is made for oa_exponent index > + * in the workaround Wa_14026633728 below as well. > + */ Delete this comment, this is not the only place where this is done in this file and the function is small enough for someone to check this automatically. > uint64_t properties[] = { > DRM_XE_OA_PROPERTY_OA_UNIT_ID, oau->oa_unit_id, > > @@ -2671,6 +2677,18 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > int len, check_idx; > u32 oa_status; > > + /* > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > + * Because of slower device mem access, OA exponent values lower than 8 > + * can result in buffer overflows. Also, update the value of oa_exponent > + * in properties[]. > + */ > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && > + igt_has_intel_wa(drm_fd, "14026633728")) { > + oa_exponent = max(oa_exponent, 8); > + properties[9] = oa_exponent; > + } Hmm, code should use tabs, not spaces. Please fix your editor to do this. > + > igt_assert(buf); > > igt_debug("Ready to read about %u bytes\n", buf_size); > -- > 2.53.0 >