From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 734B0C3DA5D for ; Mon, 22 Jul 2024 19:14:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0968410E2C0; Mon, 22 Jul 2024 19:14:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MgqDzQfW"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC0B410E2C0 for ; Mon, 22 Jul 2024 19:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721675646; x=1753211646; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=4f1/H28oGvyrRnVfmwVDPGsX0dVeZaccX9KWaOITHIc=; b=MgqDzQfWv3BuBkxwjYgFDkgCF3ofkKKU3Ut2je7xbcxyVqSG7AjkSUIN fV2WOjKC8w89cc735RxYqn8nJISKIr3gQRfvDxr6nnUsSsLq2oY+U8GJ6 vffNuhyVlCEMtGXqnaCxb5LeeS/PXgtl/y3KHpjx2GCcwHIiwdDG1vHh/ h8GMwoKR2Xcz/nKnvlNHQgGDXKtCFnFuiN/CncNPBZSYO2PZbqWpUc5I2 TlwpYpmKlCs6aQKRairnTaCt28FIsCZGqNx4/wDMCh07JLXnRZOxGYeDD CE3BsP3BRALmp8mzPAncVXrF1WLRDZWDnBCYP9lDy+V+e4yxrRVp4VFkp g==; X-CSE-ConnectionGUID: Wt4bKH+hT2OD7a565LhU5Q== X-CSE-MsgGUID: AyPE6oJ7QPG1rNu7oPmPIA== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="23026450" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="23026450" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 12:14:05 -0700 X-CSE-ConnectionGUID: pWouuAlcSGWU1H2vBzoMlQ== X-CSE-MsgGUID: ZChXtIYaRI+Dyki6OFkA0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="51630158" Received: from dmprieto-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.48.92]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 12:14:05 -0700 Date: Mon, 22 Jul 2024 11:53:57 -0700 Message-ID: <87bk2pcl6i.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lucas De Marchi Cc: Subject: Re: [PATCH i-g-t] lib/xe/oa: Handle SIMD16_EU_PER_DSS In-Reply-To: <20240722190717.57192-1-lucas.demarchi@intel.com> References: <20240722190717.57192-1-lucas.demarchi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 22 Jul 2024 12:07:17 -0700, Lucas De Marchi wrote: > > Handle SIMD16_EU_PER_DSS the same way EU_PER_DSS is. Since this function > is mixing information from hwconfig and the topo query, this should be > more correct as now the numbers from the query match the hwconfig. > > This fixes the assert triggering in the default case because > SIMD16_EU_PER_DSS was not handled: > > (xe_oa:4511) CRITICAL: Test assertion failure function xe_fill_topology_info, file ../lib/xe/xe_oa.c:532: > (xe_oa:4511) CRITICAL: Failed assertion: 0 > (xe_oa:4511) CRITICAL: Last errno: 2, No such file or directory > Test xe_oa failed. Reviewed-by: Ashutosh Dixit > > Cc: Ashutosh Dixit > Signed-off-by: Lucas De Marchi > --- > lib/xe/xe_oa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c > index 797458439..4764ed1fc 100644 > --- a/lib/xe/xe_oa.c > +++ b/lib/xe/xe_oa.c > @@ -521,6 +521,7 @@ xe_fill_topology_info(int drm_fd, uint32_t device_id, uint32_t *topology_size) > ptr += ptopo->subslice_stride; > break; > case DRM_XE_TOPO_EU_PER_DSS: > + case DRM_XE_TOPO_SIMD16_EU_PER_DSS: > for (i = 0; i < ptopo->max_subslices; i++) { > memcpy(ptr, topo->mask, ptopo->eu_stride); > ptr += ptopo->eu_stride; > -- > 2.43.0 >