Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kunal Joshi <kunal1.joshi@intel.com>, igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: Re: [PATCH i-g-t 0/2] add new test for dark screen detection
Date: Wed, 13 Dec 2023 12:37:59 +0200	[thread overview]
Message-ID: <87bkauwfp4.fsf@intel.com> (raw)
In-Reply-To: <20231213103442.2599632-1-kunal1.joshi@intel.com>

On Wed, 13 Dec 2023, Kunal Joshi <kunal1.joshi@intel.com> wrote:
> dark screen detection feature when enable will monitor frames
> and if black frame is detcted it will raise drm_error, added
> two tests for positive (black frame) and negative case (white frame)

Please settle on either "darkscreen" or "dark_screen" throughout the
kernel and igt, and stick to it. Either one is fine, but please don't
mix.

And please figure out the design [1].

BR,
Jani.


[1] https://lore.kernel.org/r/87sf46whjj.fsf@intel.com


>
> Kunal Joshi (2):
>   lib/igt_debugfs: added helper to enable/disable dark screen detection
>   tests/intel/kms_dark_screen_detection: Added IGT for validating dark
>     screen detection
>
>  lib/igt_debugfs.c                      |  39 +++++
>  lib/igt_debugfs.h                      |   2 +
>  tests/intel/kms_darkscreen_detection.c | 196 +++++++++++++++++++++++++
>  tests/meson.build                      |   1 +
>  4 files changed, 238 insertions(+)
>  create mode 100644 tests/intel/kms_darkscreen_detection.c

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2023-12-13 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 10:34 [PATCH i-g-t 0/2] add new test for dark screen detection Kunal Joshi
2023-12-13 10:34 ` [PATCH i-g-t 1/2] lib/igt_debugfs: added helper to enable/disable " Kunal Joshi
2023-12-13 10:34 ` [PATCH i-g-t 2/2] tests/intel/kms_dark_screen_detection: Added IGT for validating " Kunal Joshi
2023-12-13 10:52   ` Jani Nikula
2023-12-13 10:37 ` Jani Nikula [this message]
2023-12-13 13:05 ` ✗ GitLab.Pipeline: warning for add new test for " Patchwork
2023-12-13 13:35 ` ✓ CI.xeBAT: success " Patchwork
2023-12-13 13:44 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkauwfp4.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox