From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <SRS0=ONlT=TE=lists.freedesktop.org=igt-dev-bounces@kernel.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4AC6910E30C
 for <igt-dev@lists.freedesktop.org>; Mon, 21 Feb 2022 20:29:34 +0000 (UTC)
Date: Mon, 21 Feb 2022 12:29:33 -0800
Message-ID: <87bkz06k0i.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
In-Reply-To: <20220221102423.8089-3-anshuman.gupta@intel.com>
References: <20220221102423.8089-1-anshuman.gupta@intel.com>	<20220221102423.8089-3-anshuman.gupta@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] test/perf_pmu: Change module
 unload assertion
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org, petri.latvala@intel.com
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 21 Feb 2022 02:24:23 -0800, Anshuman Gupta wrote:
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 4f3cb6145..a7f26c80f 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -2101,7 +2101,7 @@ static void test_unload(unsigned int num_engines)
>
>		igt_debug("Read %d events from perf and trial unload\n", count);
>		pmu_read_multi(fd[0], count, buf);
> -		igt_assert_eq(__igt_i915_driver_unload(NULL), IGT_EXIT_SKIP);
> +		igt_assert_neq(__igt_i915_driver_unload(NULL), 0);

To be completely equivalent to IGT_EXIT_SKIP (before we broke it), I think
let us pass in a 'who' and make the condition: "ret != 0 && 'who' indicates
it is i915 which failed to unload".