From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable
Date: Fri, 31 Jan 2020 19:37:45 -0800 [thread overview]
Message-ID: <87blqj565y.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200131171150.8333-1-antonio.argenziano@intel.com>
On Fri, 31 Jan 2020 09:11:50 -0800, Antonio Argenziano wrote:
> The gtt tests try to verify that a gtt mapped area can be used as an
> sseu pointer so it wouldn't make sense to run those when gtt mapping is
> not available.
>
> v2:
> - Move require in subtest definition. (Ashutosh)
>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Dixit Ashutosh <ashutosh.dixit@intel.com>
> ---
> tests/i915/gem_ctx_sseu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
> index 38dc584b..b5e9658e 100644
> --- a/tests/i915/gem_ctx_sseu.c
> +++ b/tests/i915/gem_ctx_sseu.c
> @@ -528,8 +528,11 @@ igt_main
> igt_subtest("invalid-sseu")
> test_invalid_sseu(fd);
>
> - igt_subtest("ggtt-args")
> + igt_subtest("ggtt-args") {
> + gem_require_mappable_ggtt(fd);
> +
> test_ggtt_args(fd);
> + }
>
> igt_subtest("engines")
> test_engines(fd);
> --
> 2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-01 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:11 [igt-dev] [PATCH i-g-t v2] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable Antonio Argenziano
2020-01-31 18:22 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable (rev3) Patchwork
2020-02-01 3:37 ` Dixit, Ashutosh [this message]
2020-02-02 10:31 ` [igt-dev] [PATCH i-g-t v2] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable Chris Wilson
2020-02-03 16:37 ` Antonio Argenziano
2020-02-04 11:31 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blqj565y.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=antonio.argenziano@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox