From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3E2DC36008 for ; Wed, 26 Mar 2025 22:24:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 885CC10E09C; Wed, 26 Mar 2025 22:24:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="F2sAYBRd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D79010E09C for ; Wed, 26 Mar 2025 22:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743027863; x=1774563863; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5zxDytWxnpIt5GK+d48EZ9tgYNymmWNukz2ivQFtpSA=; b=F2sAYBRdvN5Wl+pYflYLBolpFK07oRhz1urwS1DTBZeOc4jYlEbw7WDN tK6PVv/u+woGq4YUwMt0+b+u5FrwcfzrejJptLn3njbCaCZX7Xpxynm1q ybjGlmarzJiF85vDmjG8X3d8RdX9y1pjVrq4V8bTp7Abr8zdFs3bekuoY flToqo/bICZqydKVHVyh5zQiGKd+Cwbr/VhzH5alVEEIU8os6+QlV02LP mSXt4LFyn7Z2sp0gMTjYFtqwJYdIDeTSmplRk2BSQ2EeXSuxrdpYTd44H GRMbsFWUouxlIxMQMfRt65vh4PCpoXJ1ShlRXINoGojcKKO2ZYtwkT+3N g==; X-CSE-ConnectionGUID: KxhDv8ffRNOlI1wFtM6m+w== X-CSE-MsgGUID: EC+4bQBaQGS+goIfSO09xw== X-IronPort-AV: E=McAfee;i="6700,10204,11385"; a="55705562" X-IronPort-AV: E=Sophos;i="6.14,279,1736841600"; d="scan'208";a="55705562" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2025 15:24:21 -0700 X-CSE-ConnectionGUID: WjnrFn7ISgacWT5qmUc1dA== X-CSE-MsgGUID: Bg4BxOhaR5ersho2tOlXCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,279,1736841600"; d="scan'208";a="125385284" Received: from rrodri4-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.216.73]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2025 15:24:21 -0700 Date: Wed, 26 Mar 2025 15:24:20 -0700 Message-ID: <87cye3ig6j.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t] tests/intel/xe_oa: Print oa_status value in the helper In-Reply-To: <20250326221729.884253-1-umesh.nerlige.ramappa@intel.com> References: <20250326221729.884253-1-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 26 Mar 2025 15:17:29 -0700, Umesh Nerlige Ramappa wrote: > > OA status value is useful when any bits are set. Print the value in the > helper, so that each call to fetch the oa_status does not need to print > the debug message explicitly. > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index caf713c2a6df..0e9fa966464a 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -383,6 +383,9 @@ static u32 get_stream_status(int fd) > > do_ioctl(fd, DRM_XE_OBSERVATION_IOCTL_STATUS, &status); > > + if (status.oa_status) Maybe we should even delete this if, just print unconditionally? Can do it while merging, no need to resend patch. In any case: Reviewed-by: Ashutosh Dixit > + igt_debug("oa status %llx\n", status.oa_status); > + > return status.oa_status; > } > > @@ -1337,7 +1340,6 @@ read_2_oa_reports(int format_id, > ; > if (errno == EIO) { > oa_status = get_stream_status(stream_fd); > - igt_debug("oa_status %#x\n", oa_status); > continue; > } > > @@ -1773,7 +1775,6 @@ static void test_oa_exponents(const struct drm_xe_engine_class_instance *hwe) > ; > if (errno == EIO) { > oa_status = get_stream_status(stream_fd); > - igt_debug("oa_status %#x\n", oa_status); > continue; > } > > @@ -2505,7 +2506,6 @@ test_non_zero_reason(const struct drm_xe_engine_class_instance *hwe, size_t oa_b > (len == -1 && (errno == EINTR || errno == EIO)))) { > if (errno == EIO) { > oa_status = get_stream_status(stream_fd); > - igt_debug("oa_status %#x\n", oa_status); > igt_assert(!(oa_status & DRM_XE_OASTATUS_BUFFER_OVERFLOW)); > } > if (len > 0) > -- > 2.43.0 >