From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 931BDC282C6 for ; Tue, 4 Mar 2025 00:28:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4882210E4EF; Tue, 4 Mar 2025 00:28:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Jtsp2gMO"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id E129510E4EF for ; Tue, 4 Mar 2025 00:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741048089; x=1772584089; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=0hB8Qm7/+0INDxYNUcS/rZa+z9whMPuxNS1ZAbbHGDQ=; b=Jtsp2gMOJXoVLQ409P3pKzc6GCfcCIIHTNXjjQ0SJrsXE5ohOjSM12/E C6V0YOVADeEoUrm068Mnc0i6umHDhlF26ZH/3uwklatSINmEnll7dka0i GccyOXHsH7j+7B7ewTQUt93hqQq9Oo8n/auUVWYtQuylhk62AghpsZfMy 695kodaewHfZgQbJPPF2H4PCrZlL1aFA+n/X6AgDvmIz5DeR3vfQVWbpj LtqJLq8fFIZvUMCHcXrEsVIuvxGrvCHqgwj0oSkree9tf9PIjCY9Utmrj VNYdMOXodmEzFXWJeF1DsGIYIpyFYA6PFbSHu/ghFfqdJIHrYVkHpIX6x A==; X-CSE-ConnectionGUID: BuVXj2WqQwGTSWdSCn+y1A== X-CSE-MsgGUID: enUvSeFiSYa1IZq4VqksxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11362"; a="41974648" X-IronPort-AV: E=Sophos;i="6.13,331,1732608000"; d="scan'208";a="41974648" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 16:28:09 -0800 X-CSE-ConnectionGUID: PUcuS6X2SVymtBZ10LUO9Q== X-CSE-MsgGUID: /uzMUb77RpORm4L5+3ch0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="118053085" Received: from peggykes-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.209.91]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 16:28:09 -0800 Date: Mon, 03 Mar 2025 16:28:08 -0800 Message-ID: <87cyextzaf.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH i-g-t v2 08/14] tests/intel/xe_oa: Simplify the buffer-fill test In-Reply-To: <20250303231502.135720-9-umesh.nerlige.ramappa@intel.com> References: <20250303231502.135720-1-umesh.nerlige.ramappa@intel.com> <20250303231502.135720-9-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 03 Mar 2025 15:14:56 -0800, Umesh Nerlige Ramappa wrote: > > static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_class_instance *hwe) > { > @@ -1092,6 +1093,7 @@ init_sys_info(void) > > rc_width = 1920; > rc_height = 1080; > + buffer_fill_size = SZ_16M; Sorry, missed this earlier. Note that there is a default_oa_buffer_size, just below. Can we use that or we need this new buffer_fill_size variable? The kernel will return a constant default_oa_buffer_size of 16 M (at least for now). We can fix this later too if needed, so not need to spin a new version for now for this. We can do this if we see any other reason for a new version, till now doesn't look like it. > oa_exponent_default = max_oa_exponent_for_period_lte(1000000); > > default_oa_buffer_size = get_default_oa_buffer_size(drm_fd);