Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/xe_query: Also allow IP version less than 20 for BMG media
Date: Mon, 22 Jul 2024 11:53:44 -0700	[thread overview]
Message-ID: <87cyn5cl6v.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240722183511.1934050-1-matthew.d.roper@intel.com>

On Mon, 22 Jul 2024 11:35:10 -0700, Matt Roper wrote:
>
> Since BMG has a media version of 13.01, MTL/ARL are no longer the only
> cases where we'll see IP versions lower than 20.  Add one more exception
> to the final GT IP version sanity check.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2238
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  tests/intel/xe_query.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
> index 84df24f49..c13613e0a 100644
> --- a/tests/intel/xe_query.c
> +++ b/tests/intel/xe_query.c
> @@ -331,11 +331,16 @@ test_query_gt_list(int fd)
>				igt_assert_lte(1270, verx100);
>
>			/*
> -			 * Aside from MTL/ARL, all version numbers should be
> -			 * 20.00 or higher.
> +			 * Aside from MTL/ARL and media on BMG, all version
> +			 * numbers should be 20.00 or higher.
>			 */
> -			if (!IS_METEORLAKE(dev_id))
> -				igt_assert_lte(20, gt_list->gt_list[i].ip_ver_major);
> +			if (IS_METEORLAKE(dev_id))
> +				continue;
> +			if (gt_list->gt_list[i].type == DRM_XE_QUERY_GT_TYPE_MEDIA &&
> +			    IS_BATTLEMAGE(dev_id))
> +				continue;
> +
> +			igt_assert_lte(20, gt_list->gt_list[i].ip_ver_major);
>		}
>	}
>  }
> --
> 2.45.2
>

  reply	other threads:[~2024-07-22 19:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 18:35 [PATCH i-g-t] tests/xe_query: Also allow IP version less than 20 for BMG media Matt Roper
2024-07-22 18:53 ` Dixit, Ashutosh [this message]
2024-07-22 19:15 ` ✓ CI.xeBAT: success for " Patchwork
2024-07-22 20:26   ` Matt Roper
2024-07-22 19:21 ` [PATCH i-g-t] " Gustavo Sousa
2024-07-22 19:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-07-22 21:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-07-23 10:50 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyn5cl6v.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox