From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8ABB10E20C for ; Wed, 14 Dec 2022 03:13:27 +0000 (UTC) Date: Tue, 13 Dec 2022 19:11:33 -0800 Message-ID: <87cz8mel22.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: igt-dev@lists.freedesktop.org In-Reply-To: <87edt2enr6.wl-ashutosh.dixit@intel.com> References: <20221213183728.2290910-1-ashutosh.dixit@intel.com> <87edt2enr6.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t 0/4] i915/i915_hwmon: General verification of hwmon attributes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Badal Nilawar Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, 13 Dec 2022 18:13:17 -0800, Dixit, Ashutosh wrote: > > On Tue, 13 Dec 2022 10:37:24 -0800, Ashutosh Dixit wrote: > > > > Ensure we can read all hwmon attributes. For writable attributes, also > > ensure the read value approximately matches the written value, taking the > > clamping of writes into account. > > > > v2: Added new patch "lib/igt_sysfs: Make it easier to extend verification > > of clamped sysfs attr". No changes to previous patches. > > Please do *NOT* review this or previous versions of these patches. I am > sending out a new version with some changes soon. Please review v4. In v4 I have dropped the concept of a 'clamped' sysfs attribute, it is not necessary. All we need is a writable attribute for which the read values will match the written values for a few points across the range of all possible values. So please don't review v1 through v3, please only review v4. Thanks. -- Ashutosh