From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B75D10E435 for ; Tue, 1 Nov 2022 23:04:51 +0000 (UTC) Date: Tue, 01 Nov 2022 16:04:29 -0700 Message-ID: <87cza65laa.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Mark Yacoub In-Reply-To: <20221101163042.942023-1-markyacoub@chromium.org> References: <20221101143743.355364-1-markyacoub@chromium.org> <20221101163042.942023-1-markyacoub@chromium.org> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH] [NEW]kms_chamelium: Add new EDID stress resolution test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, khaled.almahallawy@intel.com, vsuley@google.com, markyacoub@google.com, igt-dev@lists.freedesktop.org, kalin@google.com, seanpaul@chromium.org, ihf@google.com, matthewtlam@google.com, petri.latvala@intel.com, amstan@chromium.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, 01 Nov 2022 09:30:42 -0700, Mark Yacoub wrote: > +static void edid_stress_resolution(data_t *data, struct chamelium_port *= port, > + monitor_edid edids_list[], > + size_t edids_list_len) > +{ > + int i; > + struct chamelium *chamelium =3D data->chamelium; > + struct udev_monitor *mon =3D igt_watch_uevents(); > + > + for (i =3D 0; i < edids_list_len; ++i) { > + struct chamelium_edid *chamelium_edid; > + drmModeModeInfo mode; > + struct igt_fb fb =3D { 0 }; > + igt_output_t *output; > + enum pipe pipe; > + bool is_video_stable; > + int screen_res_w, screen_res_h; > + > + monitor_edid *monitor_edid =3D &edids_list[i]; No warnings please. ../tests/chamelium/kms_chamelium.c: In function =A1edid_stress_resolution= =A2: ../tests/chamelium/kms_chamelium.c:2570:31: warning: declaration of =A1moni= tor_edid=A2 shadows a global declaration [-Wshadow] 2570 | monitor_edid *monitor_edid =3D &edids_list[i]; | ^~~~~~~~~~~~ In file included from ../lib/monitor_edids/dp_edids.h:15, from ../tests/chamelium/kms_chamelium.c:33: ../lib/monitor_edids/monitor_edids_helper.h:25:3: note: shadowed declaratio= n is here 25 | } monitor_edid; | ^~~~~~~~~~~~