From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4794710EDC8 for ; Thu, 21 Apr 2022 23:26:23 +0000 (UTC) Date: Thu, 21 Apr 2022 16:26:22 -0700 Message-ID: <87czhadnmp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Anshuman Gupta In-Reply-To: <20220421170245.11898-2-anshuman.gupta@intel.com> References: <20220421170245.11898-1-anshuman.gupta@intel.com> <20220421170245.11898-2-anshuman.gupta@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t 1/3] test: i915_pm_rpm: init devid in setup_envirnoment List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, 21 Apr 2022 10:02:43 -0700, Anshuman Gupta wrote: > > Refactor out devid initialization out of init_mode_set_data(). > Initialize it in setup_environment(). Reviewed-by: Ashutosh Dixit > Signed-off-by: Anshuman Gupta > --- > tests/i915/i915_pm_rpm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c > index 461730e8a..2cc89eef2 100644 > --- a/tests/i915/i915_pm_rpm.c > +++ b/tests/i915/i915_pm_rpm.c > @@ -409,7 +409,6 @@ static void init_mode_set_data(struct mode_set_data *data) > } > > igt_display_require(&data->display, drm_fd); > - data->devid = intel_get_drm_devid(drm_fd); > init_modeset_cached_params(&ms_data); > } > > @@ -797,6 +796,8 @@ static bool setup_environment(bool display_disabled) > debugfs = igt_debugfs_dir(drm_fd); > igt_require(debugfs != -1); > > + ms_data.devid = intel_get_drm_devid(drm_fd); > + > if (!display_disabled) > init_mode_set_data(&ms_data); > > -- > 2.26.2 >