From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AB8B6ED9A for ; Tue, 4 Feb 2020 06:15:44 +0000 (UTC) Date: Mon, 03 Feb 2020 22:15:43 -0800 Message-ID: <87d0au514g.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200204060027.GA13720@intel.com> References: <20200131173109.12527-1-ramalingam.c@intel.com> <20200131173109.12527-3-ramalingam.c@intel.com> <875zgq6edi.wl-ashutosh.dixit@intel.com> <87h806521k.wl-ashutosh.dixit@intel.com> <20200204060027.GA13720@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ramalingam C Cc: igt-dev List-ID: On Mon, 03 Feb 2020 22:00:27 -0800, Ramalingam C wrote: > > On 2020-02-03 at 21:55:51 -0800, Dixit, Ashutosh wrote: > > On Fri, 31 Jan 2020 21:55:05 -0800, Dixit, Ashutosh wrote: > > > > > > On Fri, 31 Jan 2020 09:31:02 -0800, Ramalingam C wrote: > > > > > > > > Skip the test if the tiling is not supported on the platforms. > > > > > > > > Signed-off-by: Ramalingam C > > > > --- > > > > tools/intel_dp_compliance.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c > > > > index 5cc3d37a71d6..8f4ea3f3d328 100644 > > > > --- a/tools/intel_dp_compliance.c > > > > +++ b/tools/intel_dp_compliance.c > > > > @@ -1043,6 +1043,8 @@ int main(int argc, char **argv) > > > > drm_fd = drm_open_driver(DRIVER_ANY); > > > > gen = intel_gen(intel_get_drm_devid(drm_fd)); > > > > > > > > + /* Set tiling is not supported on newer platforms */ > > > > + gem_require_mappable_ggtt(drm_fd); > > > > > > But the test exclusively uses LOCAL_DRM_FORMAT_MOD_NONE? We should see if > > > it can use device_coherent() or see if we can drop this from this series > > > for now and revisit later with the other display tests? > > > > I think this can just use device_coherent(). > Ashutosh, > > Still we have the set_tiling used in this flow. As per our discussion we > should skip when we try to do legacy tiling. Am I missing something > here? Afais set_tiling is not used, only LOCAL_DRM_FORMAT_MOD_NONE is used. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev