From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Swap args to intel_require_memory()
Date: Mon, 11 Mar 2019 17:31:09 +0200 [thread overview]
Message-ID: <87d0mxtole.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190311141801.5393-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> It should be (count, size)!
/o\
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_ppgtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
> index 9409bef14..ae9869c2c 100644
> --- a/tests/i915/gem_ppgtt.c
> +++ b/tests/i915/gem_ppgtt.c
> @@ -97,7 +97,7 @@ static void fork_rcs_copy(int timeout, uint32_t final,
> mem_per_child = SIZE;
> if (flags & CREATE_CONTEXT)
> mem_per_child += 2 * 128 * 1024; /* rough context sizes */
> - intel_require_memory(mem_per_child, count, CHECK_RAM);
> + intel_require_memory(count, mem_per_child, CHECK_RAM);
>
> for (int child = 0; child < count; child++) {
> int fd = drm_open_driver(DRIVER_INTEL);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-11 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:18 [Intel-gfx] [PATCH i-g-t] i915/gem_ppgtt: Swap args to intel_require_memory() Chris Wilson
2019-03-11 14:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-11 15:31 ` Mika Kuoppala [this message]
2019-03-11 16:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0mxtole.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox