From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4907E10E01F for ; Fri, 10 Mar 2023 10:52:23 +0000 (UTC) Message-ID: <87e775e9-e63a-1011-ad82-3e1e513c11bc@linux.intel.com> Date: Fri, 10 Mar 2023 11:52:15 +0100 MIME-Version: 1.0 Content-Language: en-US To: =?UTF-8?Q?Zbigniew_Kempczy=c5=84ski?= , igt-dev@lists.freedesktop.org References: <20230310082326.12088-1-zbigniew.kempczynski@intel.com> <20230310082326.12088-18-zbigniew.kempczynski@intel.com> From: "Das, Nirmoy" In-Reply-To: <20230310082326.12088-18-zbigniew.kempczynski@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t 17/18] xe_mmap: skip VRAM tests if no VRAM is found List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 3/10/2023 9:23 AM, Zbigniew Kempczyński wrote: > From: Mauro Carvalho Chehab > > Instead of producing an error, if there's no VRAM, the test > should be skipped. There's a logic there that would be doing > that, except that it doesn't really work :-) > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Zbigniew Kempczyński > --- > tests/xe/xe_mmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c > index 9dce6adbe2..6b313a1895 100644 > --- a/tests/xe/xe_mmap.c > +++ b/tests/xe/xe_mmap.c > @@ -42,8 +42,7 @@ test_mmap(int fd, uint32_t flags) > uint64_t mmo; > void *map; > > - if (flags & vram_memory(fd, 0)) > - igt_require(xe_has_vram(fd)); This check should go to the igt_main instead. Nirmoy > + igt_require_f(flags, "Device doesn't support such memory region\n"); > > bo = xe_bo_create_flags(fd, 0, 4096, flags); > mmo = xe_bo_mmap_offset(fd, bo);