From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8260FCD13D3 for ; Thu, 30 Apr 2026 06:40:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1428610E15B; Thu, 30 Apr 2026 06:40:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LnO8vupe"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27D5410E15B for ; Thu, 30 Apr 2026 06:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777531229; x=1809067229; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=LCo7lr7CQZLCmxKGAf9NScS+/483Vd4jgIooEF12gvw=; b=LnO8vupePwjgoQVpIRslidDyj39LucXdYHSnecnqudOzlyHamkgGmDi4 FTyNgwV1y6+aH2Q6uOO2puLPskyYPCq2YpRD3uaXvrTHteOR0OUcxsrxg 5llt9v73LEh+4PUOAczMBFB24NvzfY2IeJ1u6yr2nI0aLPUqY2S+C2pLf OxLQr4DBWtQZZgsLGJMnY86CZNUgpykaqcCJ8dH0cP440BD836fkwGo0E cz+MQ3PL8g2AEjDWJigAsyRUKMqNmbNE35lZmK8HN46naVpUW2KDfhCEP kCiqfetMcWMkgsY1oEkYoQa0wxfjOCHSo+MGTbL+pScGCIpafEzabCJOu w==; X-CSE-ConnectionGUID: 0lpkqrrGQ06+/J20kEPx6A== X-CSE-MsgGUID: SO+E5nZDRxWKJ8nTSavoRA== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="82337158" X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="82337158" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2026 23:40:29 -0700 X-CSE-ConnectionGUID: JloB0DHKS5Kt3kC0Podqxw== X-CSE-MsgGUID: EmOZ6fgPS8e7oLwMmlQtKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="264863403" Received: from mcarlso-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.39.91]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2026 23:40:28 -0700 Date: Wed, 29 Apr 2026 23:40:28 -0700 Message-ID: <87ecjxj6hv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: , Subject: Re: [PATCH v3] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <20260430050841.3787299-1-shekhar.chauhan@intel.com> References: <20260430050841.3787299-1-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 29 Apr 2026 22:08:41 -0700, Shekhar Chauhan wrote: > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > device mem access, OA exponent values lower than 8 can result in buffer > overflows. Bump the OA exponent value. > > v2: Fix commit title, description and code description. > v3: Check if the wa exists and reuse it, also, fix a warning for C90 > rule about using variables before all declaration statements are > executed. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..c7e756426 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -24,6 +24,7 @@ > #include "igt_device.h" > #include "igt_syncobj.h" > #include "igt_sysfs.h" > +#include "intel_wa.h" > #include "xe/xe_ioctl.h" > #include "xe/xe_query.h" > #include "xe/xe_oa.h" > @@ -2643,8 +2644,15 @@ test_buffer_fill(const struct drm_xe_oa_unit *oau) > static void > test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > { > - /* ~20 micro second period */ > - int oa_exponent = max_oa_exponent_for_period_lte(20000); > + /* > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > + * Because of slower device mem access, OA exponent values lower than 8 can > + * result in buffer overflows. > + * By default, use ~20 micro second period. > + */ > + int oa_exponent = max(max_oa_exponent_for_period_lte(20000), > + (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && > + igt_has_intel_wa(drm_fd, "14026633728") > 0) ? 8 : 0); The patch is wrong. Please read my and Gustavo's comments on v2. > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > uint64_t fmt = test_set->perf_oa_format; > size_t report_size = get_oa_format(fmt).size; > -- > 2.53.0 >