Re: [igt-dev] [CI] lib/igt_core: Enable extra kernel logs for audio debug

[Ashutosh Dixit <ashutosh.dixit@intel.com>]

On Mon, 18 Mar 2019 07:10:21 -0700, Jani Nikula wrote:
>
> On Fri, 15 Mar 2019, Ashutosh Dixit <ashutosh.dixit@intel.com> wrote:
> > For debug of audio issues in power management and driver reload tests,
> > additional kernel logs may be useful, both in dmesg as well as
> > ftrace. Add the infrastructure to generate these logs and enable these
> > logs for selected sub-tests.
> >
> > At present igt_runner and other CI infrastructure does not capture the
> > ftrace buffer. Therefore, to avoid changes to igt_runner and the CI
> > infrastructure the ftrace buffer is dumped to stdout. This is done
> > after each sub-test so the ftrace output for a subtest can be
> > associated with that subtest.
>
> Please always include a changelog compared to previous version. It's not
> obvious there was a previous version.

Sorry, this was a CI only patch (with CI in the subject) which I pushed
since v1 had broken CI. But yes, I will include the changelog in future
versions.

> Please always address the review comments! [1]

> Another review comment: Please don't use system(). Implement this in C,
> not shell script.
>
> BR,
> Jani.
>
> [1] http://marc.info/?i=87bm2dix2u.fsf@intel.com

Yes, will address the previous and present review comments and reply to
your previous email soon. Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev