public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: Drop gem_ctx_switch/heavy
Date: Tue, 15 Jan 2019 11:08:05 +0200	[thread overview]
Message-ID: <87ef9ez3t6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190114230301.32624-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Th heavy variant of gem_ctx_switch does little more than provide an
> alternate timing for the basic gem_ctx_switch; the timing only effects
> the HW and does not stress the driver any differently. As such,
> including gem_ctx_switch/heavy provides no more basic coverage for BAT
> over and above the default gem_ctx_switch and
> i915_selftests/live_contexts.
>
> It takes around 45s, of a 600s total target time for BAT.

I looked back drm-tip results and also did bugzilla searches.
drm-tip is all green for recent past and those 2 bugzilla
entries this test was in any way mentioned, are issues
where this test didn't play any particular role itself.

Heavy seems to indicate only bigger contexts for switching
so I agree with the timing argument.

These seconds are more well spent elsewhere.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 6d42792c6..da3c4c8ed 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -16,7 +16,6 @@ igt@gem_ctx_exec@basic
>  igt@gem_ctx_param@basic
>  igt@gem_ctx_param@basic-default
>  igt@gem_ctx_switch@basic-default
> -igt@gem_ctx_switch@basic-default-heavy
>  igt@gem_exec_basic@basic-blt
>  igt@gem_exec_basic@basic-bsd
>  igt@gem_exec_basic@basic-bsd1
> -- 
> 2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2019-01-15  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 23:03 [igt-dev] [PATCH i-g-t] intel-ci: Drop gem_ctx_switch/heavy Chris Wilson
2019-01-14 23:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-15  7:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-15  9:08 ` Mika Kuoppala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef9ez3t6.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox