Re: [PATCH i-g-t] lib/intel_wa: Return false for non-root users

[Gustavo Sousa <gustavo.sousa@intel.com>]

Ashutosh Dixit <ashutosh.dixit@intel.com> writes:

> Under some circurmstancs debugfs reads are initiated by non-root users. In
> these cases, just return false rather than asserting that debugfs could not
> be read.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  lib/intel_wa.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index a16ea62a4c..2d0d664f3c 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -47,6 +47,10 @@ bool igt_has_intel_wa(int drm_fd, const char *check_wa)
>  	unsigned int xe;
>  	char name[256];
>  
> +	/* If we are not root, we can't read debugfs, just return false */
> +	if (getuid() != 0)
> +		return false;

This doesn't sound right to me. The function will be lying by returning
false here and will probably make it harder to debug issues on code that
rely on having the correct result for a workaround check.

My personal take is that we probably should start avoiding having
asserts in lib/ code and defer any assertion to real test code.

--
Gustavo Sousa

> +
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
>  	igt_assert(debugfs_fd >= 0);
>  
> -- 
> 2.54.0