From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F419CD342C for ; Wed, 6 May 2026 04:25:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1432410E127; Wed, 6 May 2026 04:25:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="j2Lg/Eem"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5F3710E127 for ; Wed, 6 May 2026 04:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778041516; x=1809577516; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jPGqU7PumRAWl+Luyzo69QuWyW5W0EZTLPWXXKB3+rM=; b=j2Lg/EemNq3SLyQZ3GlyBIzhlplgdov7Of20X/ySyvZ5lE7nRiqhuOFt S5uTURQJc3N5DwGv1Oz8/A3eNorW7HDkrqU3eJRKfB6k2HQFdRGxOqJjv QJV+RGUeqVfPjn/v6nKuH1nrxVYerNZnFVFnx1ERKdHWjPDvONly1BUlK XIg0YeS4k8n7qKnWsOTXMqj0E4USU4gsETZIlZEjxzQGzB9f35prJtYrA xU7HV1izK1aW9uFsmjcY801iFM7E5qmX/vwyBLXHsu3mXBoAgEiH2qHka b3gesY579zyNAYn5sn1CrGTT55zBJzx3uDEUUwrFJLwJEMFH8070ObeCN w==; X-CSE-ConnectionGUID: BOHusYytTpWRArZLRCF1gg== X-CSE-MsgGUID: hOEh0Qp9ShKozQhiRRuRag== X-IronPort-AV: E=McAfee;i="6800,10657,11777"; a="78081066" X-IronPort-AV: E=Sophos;i="6.23,218,1770624000"; d="scan'208";a="78081066" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 21:25:16 -0700 X-CSE-ConnectionGUID: SPPi0adXRJC19nLtqnBg9A== X-CSE-MsgGUID: /RfEYnHaQ5mL3ufLZFZifg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,218,1770624000"; d="scan'208";a="266352567" Received: from maduranp-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.34.22]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 21:25:16 -0700 Date: Tue, 05 May 2026 21:25:15 -0700 Message-ID: <87fr45go5w.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: , Subject: Re: [PATCH v5 1/2] lib/intel_wa: Check for device workarounds In-Reply-To: <20260506024443.612636-2-shekhar.chauhan@intel.com> References: <20260506024443.612636-1-shekhar.chauhan@intel.com> <20260506024443.612636-2-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 05 May 2026 19:44:42 -0700, Shekhar Chauhan wrote: > > Currently, igt_has_intel_wa() only checks for GT workarounds, extending > it to ensure that it also checks for device workarounds to avoid having > device workaround checks in the code. > While at it, ensure that we do not duplicate the logic for reading from > the debugfs file by extracting it into a separate function called > debugfs_file_has_wa(). > > Signed-off-by: Shekhar Chauhan You need to get the patches from Patchwork first, and then work on them, and then send them, to pick up previous R-b's (in this case Gustavo's).