From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 4451D7B010
 for <igt-dev@lists.freedesktop.org>; Thu,  4 Nov 2021 01:43:03 +0000 (UTC)
Date: Wed, 03 Nov 2021 18:42:58 -0700
Message-ID: <87fsscd7bx.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <YYJjlvTGU25WMT2E@platvala-desk.ger.corp.intel.com>
References: <20211101165824.2810805-1-markyacoub@chromium.org>
 <YYJjlvTGU25WMT2E@platvala-desk.ger.corp.intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Use
 igt_require_intel before get_reloc_ahnd
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Petri Latvala <petri.latvala@intel.com>
Cc: chunkuang.hu@kernel.org, igt-dev@lists.freedesktop.org, seanpaul@chromium.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, Mark Yacoub <markyacoub@google.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 03 Nov 2021 03:25:26 -0700, Petri Latvala wrote:
>
> > @@ -1327,6 +1333,7 @@ static void flip_vs_cursor_busy_crc(igt_display_t=
 *display, bool atomic)
> >	igt_pipe_t *pipe_connected =3D &display->pipes[pipe];
> >	igt_plane_t *plane_primary =3D igt_pipe_get_plane_type(pipe_connected, =
DRM_PLANE_TYPE_PRIMARY);
> >	igt_crc_t crcs[2], test_crc;
> > +	igt_require_intel(display->drm_fd);
> >	uint64_t ahnd =3D get_reloc_ahnd(display->drm_fd, 0);

[76/1123] Compiling C object 'tests/59830eb@@kms_cursor_legacy@exe/kms_curs=
or_legacy.c.o'.
../tests/kms_cursor_legacy.c: In function =A1flip_vs_cursor_busy_crc=A2:
../tests/kms_cursor_legacy.c:1337:2: warning: ISO C90 forbids mixed declara=
tions and code [-Wdeclaration-after-statement]
  uint64_t ahnd =3D get_reloc_ahnd(display->drm_fd, 0);
  ^~~~~~~~

Should compile without warnings before merging.