From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id C777889FD3 for ; Mon, 28 Sep 2020 21:13:27 +0000 (UTC) Date: Mon, 28 Sep 2020 14:13:26 -0700 Message-ID: <87ft717gg9.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200903115409.GA3720@zkempczy-mobl2> References: <20200903110110.2403699-1-ayaz.siddiqui@intel.com> <20200903110110.2403699-2-ayaz.siddiqui@intel.com> <20200903115409.GA3720@zkempczy-mobl2> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: Fix device selection filter List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Ayaz A Siddiqui List-ID: On Thu, 03 Sep 2020 04:54:09 -0700, Zbigniew Kempczy=F1ski wrote: > > On Thu, Sep 03, 2020 at 04:31:09PM +0530, Ayaz A Siddiqui wrote: > > DRM subsystem filter in intel_gpu_top was not working due to missing > > PCI_SLOT_NAME property. Using the parent device in case of drm subsystem > > leads to fix this issue. > > > > Signed-off-by: Ayaz A Siddiqui > > --- > > lib/igt_device_scan.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c > > index 345bae76d..3583c69c7 100644 > > --- a/lib/igt_device_scan.c > > +++ b/lib/igt_device_scan.c > > @@ -1263,7 +1263,7 @@ bool igt_device_card_match(const char *filter, st= ruct igt_device_card *card) > > /* We take first one if more than one card matches filter */ > > dev =3D igt_list_first_entry(&igt_devs.filtered, dev, link); > > > > - __copy_dev_to_card(dev, card); > > + __copy_dev_to_card(is_pci_subsystem(dev) ? dev : dev->parent, card); > > > > return true; > > } > > The only doubt I got: - is that i915 driver behavior or all drm cards do > the same? I am not entirely sure but I will be very surprised if this is i915 driver behavior. I'd think this is a property of the drm subsystem. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev