From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CF47FF8855 for ; Tue, 5 May 2026 16:42:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 384B010EB85; Tue, 5 May 2026 16:42:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="exVJf5Ua"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2191110EB85 for ; Tue, 5 May 2026 16:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777999333; x=1809535333; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=FGZ4dYPf6dqmw7hR4fzY/xxYNL0c5ezSF3opB/4BIck=; b=exVJf5Ua0wqEXVlNTVXYZDkPmgzDpriQvruDW62V3XpcmpFSWSoKzkCe CdU/S1CpVCisL3HMhMgh1fuAhra6dDeu+Yy7luvszD73be2as4HCfpror d3xhYFQeEBlUgPViYEce2jQP3uawQpTmp289c6ahuRx6A+hFgA7hOmhWv NnupX5uqvTEWwO9xrsPNSXGYd6aauZbHUma1RlBks5teC4aIIHHchcIGr Kb8Ih4i45mtH0U57WApfs0UuT0KFinutT4VDFhDOyTOEFTMhbkn4nJXVD CpbDpu0GExVUOproVm+uB6GGoHOyskzAYq8S+GZpRPNY601XNgvge7QdK w==; X-CSE-ConnectionGUID: /T4j7foRQfm2nmKOoX+zGg== X-CSE-MsgGUID: gI8HBVhlQsizxDzyfiqv2Q== X-IronPort-AV: E=McAfee;i="6800,10657,11777"; a="78737071" X-IronPort-AV: E=Sophos;i="6.23,217,1770624000"; d="scan'208";a="78737071" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 09:42:13 -0700 X-CSE-ConnectionGUID: pjuRLj6MTlGGeOHmvaTGnQ== X-CSE-MsgGUID: JzN72XDdQUa9tZggYPF/6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,217,1770624000"; d="scan'208";a="231489689" Received: from cbrown-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.134.206]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 09:42:13 -0700 Date: Tue, 05 May 2026 09:42:11 -0700 Message-ID: <87h5olhkpo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: , Subject: Re: [PATCH v4 2/2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <20260505054741.486361-3-shekhar.chauhan@intel.com> References: <20260505054741.486361-1-shekhar.chauhan@intel.com> <20260505054741.486361-3-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 04 May 2026 22:47:41 -0700, Shekhar Chauhan wrote: > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > device mem access, OA exponent values lower than 8 can result in buffer > overflows. Bump the OA exponent value. > > Signed-off-by: Shekhar Chauhan > --- > tests/intel/xe_oa.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 988c46df6..c7e756426 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -24,6 +24,7 @@ > #include "igt_device.h" > #include "igt_syncobj.h" > #include "igt_sysfs.h" > +#include "intel_wa.h" > #include "xe/xe_ioctl.h" > #include "xe/xe_query.h" > #include "xe/xe_oa.h" > @@ -2643,8 +2644,15 @@ test_buffer_fill(const struct drm_xe_oa_unit *oau) > static void > test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > { > - /* ~20 micro second period */ > - int oa_exponent = max_oa_exponent_for_period_lte(20000); > + /* > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > + * Because of slower device mem access, OA exponent values lower than 8 can > + * result in buffer overflows. > + * By default, use ~20 micro second period. > + */ > + int oa_exponent = max(max_oa_exponent_for_period_lte(20000), > + (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && > + igt_has_intel_wa(drm_fd, "14026633728") > 0) ? 8 : 0); 0 check is not needed, just 'igt_has_intel_wa(drm_fd, "14026633728")' is sufficient. Also, can we change this code to the way it was in v2 (with an if statement). Just replace with the has_wa check and move the code below the variable declarations, it is a little bit cleaner and easier to read. > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > uint64_t fmt = test_set->perf_oa_format; > size_t report_size = get_oa_format(fmt).size; > -- > 2.53.0 >