From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1F0FF886D for ; Tue, 28 Apr 2026 17:51:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12C3110E177; Tue, 28 Apr 2026 17:51:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GBq3u3oV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8662910E177 for ; Tue, 28 Apr 2026 17:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777398670; x=1808934670; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=LdRZCSLfuvV3DgRpzRmFrhnA3VCm7EgEuinjg4MGgTg=; b=GBq3u3oV95G6hPyvqfQ0zdZgi5XhRhYmvD9xwzadc5mK42hzM8FXkV6V 149ZLp0IehFb1OitualsLMZUWP7cREERxtmCf09VSbcF1kJSXRjpAS2YB bR+0DQvRI3IR+MzUuSpN7RvlUFl3e6DvOQhJJArP2uFU+XUguLflE2mnR k5XIObtZbTNXim26/aEYoFDt/FCdvKx22Up8J7S2aVCi1GtSYdKUezNKP phzzzHzgVuk5/BsdP7PaUNhSHJS1bZbGW3qgY/GC9fOP8fAxWP0pi2mXj RyEt6UiZA95R/gN8Neg6tb8bbJq6vxAp7amtMcIqwuJAI0BOAwpVA3hTz Q==; X-CSE-ConnectionGUID: jJYHrfQ2QpOMzqRnG/krUw== X-CSE-MsgGUID: dekWfPZ/Q1i7E+K5zScz2w== X-IronPort-AV: E=McAfee;i="6800,10657,11770"; a="77481077" X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="77481077" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 10:51:10 -0700 X-CSE-ConnectionGUID: rLjL+6ffSGS1RA3pHMwfaQ== X-CSE-MsgGUID: z+AHbYUkTb2obyRq3PFvRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="257575658" Received: from rgogar-mobl2.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.161.192]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 10:51:10 -0700 Date: Tue, 28 Apr 2026 10:51:09 -0700 Message-ID: <87h5ovj7n6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Gustavo Sousa Cc: Shekhar Chauhan , Subject: Re: [PATCH v2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <877bproujr.fsf@intel.com> References: <20260427050002.3391994-1-shekhar.chauhan@intel.com> <877bproujr.fsf@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 28 Apr 2026 10:37:28 -0700, Gustavo Sousa wrote: > > Shekhar Chauhan writes: > > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > > device mem access, OA exponent values lower than 8 can result in buffer > > overflows. Bump the OA exponent value. > > > > v2: Fix commit title, description and code description. > > > > Signed-off-by: Shekhar Chauhan > > --- > > tests/intel/xe_oa.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index 988c46df6..cbc1e0d3e 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -2645,6 +2645,16 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size) > > { > > /* ~20 micro second period */ > > int oa_exponent = max_oa_exponent_for_period_lte(20000); > > + > > + /* > > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory. > > + * Because of slower device mem access, OA exponent values lower than 8 can > > + * result in buffer overflows. > > + */ > > + > > + if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && IS_CRESCENTISLAND(devid)) > > + oa_exponent = max(oa_exponent, 8); > > We have a way of querying for workarounds via debugfs (intel_wa.h). It > is probably better to use that interface instead of replicating > workaround checks in IGT. > > It currently only checks for GT workarounds, but can be easily extended > to also check for device workarounds. OK, thanks, let's do that here then. > > + > > struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau); > > uint64_t fmt = test_set->perf_oa_format; > > size_t report_size = get_oa_format(fmt).size; > > -- > > 2.53.0