Re: [PATCH] tests/kms_sysfs_edid_timing: increase thresholds

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 11 Dec 2023, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> On 2023-12-08 at 14:42:05 -0800, Charlton Lin wrote:
>> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
>> index 775211089f81..582133ea002e 100644
>> --- a/tests/kms_sysfs_edid_timing.c
>> +++ b/tests/kms_sysfs_edid_timing.c
>> @@ -26,9 +26,9 @@
>>  #include <fcntl.h>
>>  #include <sys/stat.h>
>>  
>> -#define THRESHOLD_PER_CONNECTOR		150
>> -#define THRESHOLD_PER_CONNECTOR_MEAN	140
>> -#define THRESHOLD_ALL_CONNECTORS_MEAN	100
>> +#define THRESHOLD_PER_CONNECTOR		1500
>> +#define THRESHOLD_PER_CONNECTOR_MEAN	1400
>> +#define THRESHOLD_ALL_CONNECTORS_MEAN	1000
>
> This is like increasing it ten times, add this to description.
> I am not KMS nor panel expert but is it really that long?

Would be worth investigating *why* this specific panel takes so long,
instead of allowing *all* panels to do so. We might add a regression
that slows down probing and nobody would notice.

BR,
Jani.


-- 
Jani Nikula, Intel