From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 28 Jul 2021 15:23:42 -0700 Message-ID: <87h7ge3wnl.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210728103041.1669985-2-matthew.auld@intel.com> References: <20210728103041.1669985-1-matthew.auld@intel.com> <20210728103041.1669985-2-matthew.auld@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t v2 02/11] lib/i915/gem_mman: add fixed mode to mmap__device_coherent List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Matthew Auld Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: On Wed, 28 Jul 2021 03:30:32 -0700, Matthew Auld wrote: > > diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c > index e2514f0c..222e8896 100644 > --- a/lib/i915/gem_mman.c > +++ b/lib/i915/gem_mman.c > @@ -383,9 +383,10 @@ void *__gem_mmap__device_coherent(int fd, uint32_t handle, uint64_t offset, > I915_MMAP_OFFSET_WC); > if (!ptr) > ptr = __gem_mmap__wc(fd, handle, offset, size, prot); > - > if (!ptr) > ptr = __gem_mmap__gtt(fd, handle, size, prot); > + if (!ptr) > + ptr = __gem_mmap_offset__fixed(fd, handle, offset, size, prot); Wondering if we really want 4 system calls for discrete. Maybe we can move this up to 2nd place right after __gem_mmap_offset? _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev