From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 745D66E3FB
 for <igt-dev@lists.freedesktop.org>; Mon, 10 Feb 2020 06:36:20 +0000 (UTC)
Date: Sun, 09 Feb 2020 22:36:08 -0800
Message-ID: <87h7zz7xuv.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20200210054755.GA29606@intel.com>
References: <20200207134527.17205-1-ramalingam.c@intel.com>
 <20200207134527.17205-2-ramalingam.c@intel.com>
 <158108667615.15496.13203855080851124379@skylake-alporthouse-com>
 <20200210054755.GA29606@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device
 coherent mapping instead of mmap_gtt
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 09 Feb 2020 21:47:55 -0800, Ramalingam C wrote:
>
> On 2020-02-07 at 14:44:36 +0000, Chris Wilson wrote:
> > Quoting Ramalingam C (2020-02-07 13:45:27)
> > > @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> > >         /* GEM */
> > >         igt_subtest("gem-mmap-cpu")
> > >                 gem_mmap_subtest(false);
> > > -       igt_subtest("gem-mmap-gtt")
> > > +       igt_subtest("gem-mmap-gtt") {
> > > +               gem_require_mappable_ggtt(drm_fd);
> > >                 gem_mmap_subtest(true);
> >
> > Would not the lmem bar also be susceptible to power management
> > artefacts?
> Chris,
>
> I think "gem-mmap-cpu" would do the same test with lmem, but that
> can be done when we have the uAPI for allocating from lmem, through
> another subtest say "gem-mmap-cpu-lmem"
>
> But at present "gem-mmap-gtt" will fail at platforms where mmap_gtt is
> not present. So to avoid that, could you please approve this change?

My reading was Chris is referring to using for_each_mmap_offset_type(), see
973bbbff.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev