From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 342C26E2EA for ; Mon, 14 Jan 2019 09:26:12 +0000 (UTC) From: Jani Nikula In-Reply-To: <20190111085735.10613-1-jani.nikula@intel.com> References: <20190111085735.10613-1-jani.nikula@intel.com> Date: Mon, 14 Jan 2019 11:27:48 +0200 Message-ID: <87h8eb612j.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] igt/sysfs: drop support for passing -1 fd for Intel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org List-ID: T24gRnJpLCAxMSBKYW4gMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gVGhlIHJhYmJpdCBob2xlIGdvZXMgZGVlcCBpbiB0aGlzIGNhc2UsIGJ1dCBJIGNv dWxkbid0IGZpbmQgYW55IHBsYWNlCj4gd2hlcmUgd2UnZCBzdGlsbCByZWx5IG9uIC0xIGZvciBJ bnRlbC4gRHJvcCB0aGUgcmVtYWluaW5nIHN1cHBvcnQgdG8KPiBwcmV2ZW50IGFueW9uZSBhZGRp bmcgbmV3IGNvZGUgdXNpbmcgdGhpcy4KPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA aW50ZWwuY29tPgoKUHVzaGVkIHdpdGggQ2hyaXMnIGlyYyByLWIuCgpCUiwKSmFuaS4KCgo+IC0t LQo+ICBsaWIvaWd0X3N5c2ZzLmMgfCA1MCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAy NyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9saWIvaWd0X3N5c2ZzLmMgYi9saWIvaWd0 X3N5c2ZzLmMKPiBpbmRleCBjY2UzNDJhMDU3ZTMuLmM1N2U0YWUyM2M1ZSAxMDA2NDQKPiAtLS0g YS9saWIvaWd0X3N5c2ZzLmMKPiArKysgYi9saWIvaWd0X3N5c2ZzLmMKPiBAQCAtODYsNyArODYs NyBAQCBzdGF0aWMgaW50IHdyaXRlTihpbnQgZmQsIGNvbnN0IGNoYXIgKmJ1ZiwgaW50IGxlbikK PiAgCj4gIC8qKgo+ICAgKiBpZ3Rfc3lzZnNfcGF0aDoKPiAtICogQGRldmljZTogZmQgb2YgdGhl IGRldmljZSAob3IgLTEgdG8gZGVmYXVsdCB0byBJbnRlbCkKPiArICogQGRldmljZTogZmQgb2Yg dGhlIGRldmljZQo+ICAgKiBAcGF0aDogYnVmZmVyIHRvIGZpbGwgd2l0aCB0aGUgc3lzZnMgcGF0 aCB0byB0aGUgZGV2aWNlCj4gICAqIEBwYXRobGVuOiBsZW5ndGggb2YgQHBhdGggYnVmZmVyCj4g ICAqIEBpZHg6IG9wdGlvbmFsIHBvaW50ZXIgdG8gc3RvcmUgdGhlIGNhcmQgaW5kZXggb2YgdGhl IG9wZW5lZCBkZXZpY2UKPiBAQCAtMTAwLDMzICsxMDAsMjkgQEAgY2hhciAqaWd0X3N5c2ZzX3Bh dGgoaW50IGRldmljZSwgY2hhciAqcGF0aCwgaW50IHBhdGhsZW4sIGludCAqaWR4KQo+ICB7Cj4g IAlzdHJ1Y3Qgc3RhdCBzdDsKPiAgCj4gLQlpZiAoZGV2aWNlICE9IC0xICYmIChmc3RhdChkZXZp Y2UsICZzdCkgfHwgIVNfSVNDSFIoc3Quc3RfbW9kZSkpKQo+ICsJaWYgKGRldmljZSA8IDApCj4g KwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJaWYgKGZzdGF0KGRldmljZSwgJnN0KSB8fCAhU19JU0NI UihzdC5zdF9tb2RlKSkKPiAgCQlyZXR1cm4gTlVMTDsKPiAgCj4gIAlmb3IgKGludCBuID0gMDsg biA8IDE2OyBuKyspIHsKPiAtCQlpbnQgbGVuID0gc25wcmludGYocGF0aCwgcGF0aGxlbiwgIi9z eXMvY2xhc3MvZHJtL2NhcmQlZCIsIG4pOwo+IC0JCWlmIChkZXZpY2UgIT0gLTEpIHsKPiAtCQkJ RklMRSAqZmlsZTsKPiAtCQkJaW50IHJldCwgbWFqLCBtaW47Cj4gLQo+IC0JCQlzcHJpbnRmKHBh dGggKyBsZW4sICIvZGV2Iik7Cj4gLQkJCWZpbGUgPSBmb3BlbihwYXRoLCAiciIpOwo+IC0JCQlp ZiAoIWZpbGUpCj4gLQkJCQljb250aW51ZTsKPiAtCj4gLQkJCXJldCA9IGZzY2FuZihmaWxlLCAi JWQ6JWQiLCAmbWFqLCAmbWluKTsKPiAtCQkJZmNsb3NlKGZpbGUpOwo+IC0KPiAtCQkJaWYgKHJl dCAhPSAyIHx8Cj4gLQkJCSAgICBtYWpvcihzdC5zdF9yZGV2KSAhPSBtYWogfHwKPiAtCQkJICAg IG1pbm9yKHN0LnN0X3JkZXYpICE9IG1pbikKPiAtCQkJCWNvbnRpbnVlOwo+IC0JCX0gZWxzZSB7 Cj4gLQkJCS8qIEJsZWguIFNlYXJjaCBmb3IgaW50ZWwgKi8KPiAtCQkJc3ByaW50ZihwYXRoICsg bGVuLCAiL2Vycm9yIik7Cj4gLQkJCWlmIChzdGF0KHBhdGgsICZzdCkpCj4gLQkJCQljb250aW51 ZTsKPiAtCQl9Cj4gKwkJaW50IGxlbiwgcmV0LCBtYWosIG1pbjsKPiArCQlGSUxFICpmaWxlOwo+ ICsKPiArCQlsZW4gPSBzbnByaW50ZihwYXRoLCBwYXRobGVuLCAiL3N5cy9jbGFzcy9kcm0vY2Fy ZCVkIiwgbik7Cj4gKwo+ICsJCXNwcmludGYocGF0aCArIGxlbiwgIi9kZXYiKTsKPiArCQlmaWxl ID0gZm9wZW4ocGF0aCwgInIiKTsKPiArCQlpZiAoIWZpbGUpCj4gKwkJCWNvbnRpbnVlOwo+ICsK PiArCQlyZXQgPSBmc2NhbmYoZmlsZSwgIiVkOiVkIiwgJm1haiwgJm1pbik7Cj4gKwkJZmNsb3Nl KGZpbGUpOwo+ICsKPiArCQlpZiAocmV0ICE9IDIgfHwgbWFqb3Ioc3Quc3RfcmRldikgIT0gbWFq IHx8Cj4gKwkJICAgIG1pbm9yKHN0LnN0X3JkZXYpICE9IG1pbikKPiArCQkJY29udGludWU7Cj4g IAo+ICAJCXBhdGhbbGVuXSA9ICdcMCc7Cj4gIAkJaWYgKGlkeCkKPiBAQCAtMTM5LDcgKzEzNSw3 IEBAIGNoYXIgKmlndF9zeXNmc19wYXRoKGludCBkZXZpY2UsIGNoYXIgKnBhdGgsIGludCBwYXRo bGVuLCBpbnQgKmlkeCkKPiAgCj4gIC8qKgo+ICAgKiBpZ3Rfc3lzZnNfb3BlbjoKPiAtICogQGRl dmljZTogZmQgb2YgdGhlIGRldmljZSAob3IgLTEgdG8gZGVmYXVsdCB0byBJbnRlbCkKPiArICog QGRldmljZTogZmQgb2YgdGhlIGRldmljZQo+ICAgKiBAaWR4OiBvcHRpb25hbCBwb2ludGVyIHRv IHN0b3JlIHRoZSBjYXJkIGluZGV4IG9mIHRoZSBvcGVuZWQgZGV2aWNlCj4gICAqCj4gICAqIFRo aXMgb3BlbnMgdGhlIHN5c2ZzIGRpcmVjdG9yeSBjb3JyZXNwb25kaW5nIHRvIGRldmljZSBmb3Ig dXNlCj4gQEAgLTE2MCw3ICsxNTYsNyBAQCBpbnQgaWd0X3N5c2ZzX29wZW4oaW50IGRldmljZSwg aW50ICppZHgpCj4gIAo+ICAvKioKPiAgICogaWd0X3N5c2ZzX3NldF9wYXJhbWV0ZXJzOgo+IC0g KiBAZGV2aWNlOiBmZCBvZiB0aGUgZGV2aWNlIChvciAtMSB0byBkZWZhdWx0IHRvIEludGVsKQo+ ICsgKiBAZGV2aWNlOiBmZCBvZiB0aGUgZGV2aWNlCj4gICAqIEBwYXJhbWV0ZXI6IHRoZSBuYW1l IG9mIHRoZSBwYXJhbWV0ZXIgdG8gc2V0Cj4gICAqIEBmbXQ6IHByaW50Zi1lc3F1ZSBmb3JtYXQg c3RyaW5nCj4gICAqCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNz IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpp Z3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK