From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBEC2CD6E57 for ; Wed, 3 Jun 2026 18:43:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63625112277; Wed, 3 Jun 2026 18:43:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dOviEVq9"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E7C2112275 for ; Wed, 3 Jun 2026 18:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780512163; x=1812048163; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=/3ashz/v+8sYjgxzBWJGTQMAv4nDM168aMyaS0P2I68=; b=dOviEVq9jCOBCNq8hRtGxis409UvicLcryjic9bdlUFaM+GMX5h9hOE/ Yp96Ua3VSGJe/1NwOaN/Qw2n1SvBXKR+93EEjG1rHEln+dzBwQ2qF9Aww hOP5SlbVVAHkGyMT0WYSnJloPOFWMwyXIJYIH/RE72mmUMd6HDf8XmNfD 5taHB6aFWSipXqz9keY746YrPxCp2MD9J/YltiIliFYC8hfWDrsLHxbEo hBTWMZLeSey/5TVuyjdaIwUbbav3rG8eV5gvb4TRx0YOpkiguRuxyMidc x4ntOs/R4S4sLj/VAUhhy+mqzK0J9ssRHNvfkZv+srJfGY6SFI1NRJod5 g==; X-CSE-ConnectionGUID: VOSt/RvRSOCueG8LfZeK9Q== X-CSE-MsgGUID: cFBorycNSjuaAChmBFL2OA== X-IronPort-AV: E=McAfee;i="6800,10657,11806"; a="81460336" X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="81460336" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 11:42:42 -0700 X-CSE-ConnectionGUID: 6kSK+7cJQvmyDVCV5t39IA== X-CSE-MsgGUID: phLoWNb9RlKjvKzRVq3gOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="244166003" Received: from apoorva1-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.34.170]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 11:42:42 -0700 Date: Wed, 03 Jun 2026 11:42:41 -0700 Message-ID: <87ik7z79em.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: , , , Subject: Re: [PATCH i-g-t] include/drm-uapi/xe_drm: Add srcid to drm_xe_fault struct In-Reply-To: <87jysf7d3y.wl-ashutosh.dixit@intel.com> References: <20260603150122.3750541-1-jonathan.cavitt@intel.com> <87jysf7d3y.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 03 Jun 2026 10:22:41 -0700, Dixit, Ashutosh wrote: > > On Wed, 03 Jun 2026 08:01:22 -0700, Jonathan Cavitt wrote: > > > > Add srcid to drm_xe_fault struct, aligning with a KMD change. > > Additionally, add logging for the new information to the associated > > xe_vm test. > > Please follow the format of previous commit messages to > include/drm-uapi/xe_drm.h and include the kernel commit sha > include/drm-uapi/xe_drm.h is being sync'd till. What I mean is, no point sending the IGT patch for this till the kernel patch is merged, anyway 'Test-with' doesn't work for Xe. And, after kernel patch is merged, rather than just this change, the IGT uapi header should be sync'd with the kernel uapi header using make INSTALL_HDR_PATH= headers_install > > > > > Signed-off-by: Jonathan Cavitt > > Cc: Michal Mrozek > > --- > > include/drm-uapi/xe_drm.h | 4 ++-- > > tests/intel/xe_vm.c | 1 + > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h > > index 5a96a7910b..273bac9e1f 100644 > > --- a/include/drm-uapi/xe_drm.h > > +++ b/include/drm-uapi/xe_drm.h > > @@ -1290,8 +1290,8 @@ struct xe_vm_fault { > > #define FAULT_LEVEL_PML4 3 > > #define FAULT_LEVEL_PML5 4 > > __u8 fault_level; > > - /** @pad: MBZ */ > > - __u8 pad; > > + /** @srcid: ID of the faulting hardware unit */ > > + __u8 srcid; > > /** @reserved: MBZ */ > > __u64 reserved[4]; > > }; > > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c > > index 408bfdb718..260dae9cae 100644 > > --- a/tests/intel/xe_vm.c > > +++ b/tests/intel/xe_vm.c > > @@ -3023,6 +3023,7 @@ static void print_pf(struct xe_vm_fault *fault) > > igt_debug("access type = %u\n", fault->access_type); > > igt_debug("fault type = %u\n", fault->fault_type); > > igt_debug("fault level = %u\n", fault->fault_level); > > + igt_debug("srcid = 0x%08x\n", fault->srcid); > > igt_debug("\n"); > > } > > > > -- > > 2.53.0 > >