From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 664C8FF886D for ; Tue, 28 Apr 2026 17:15:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1068310EC1E; Tue, 28 Apr 2026 17:15:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="I5Z6Ejjc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE8E410EC1E for ; Tue, 28 Apr 2026 17:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777396501; x=1808932501; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=BPTmIUulQY7D270B5RrNi5W27EQbrQWK2k9/mY13e2E=; b=I5Z6EjjcGgnknlEF5jozpJJf0RqXx4U+JzG9SX+w7MiPSG7gfTARGjV/ OHdaZs3tg8h1dAumFOmKa7aK9SyjUHheVW8TIsTvNFN5jgeue8Isq6Brh 9bjaO4Ed46IKO1eWPrjSPy2c/uRIBKAXpqk+OGtNW+mFIytJjOO+Ymmjm Axl9UQTU/8HoPbjk3xoA6ambpJur7mv8pYZuW6N+kLizCDBoS7C5EF86j O0/K9G+1kePoT+1O1aZJtk24aLxzn22jYz5xSFUfD+fPHlAkoloJLsiuX F8LADDLDvN+gGtSDKnPYBunK10wZq/KPrDfP1Mb1y98MBF/IfDKafLNFr A==; X-CSE-ConnectionGUID: 500jPe80S1OT+Q+XVUPdzQ== X-CSE-MsgGUID: 8XMH6jObSV+wzqUZdwdZ0A== X-IronPort-AV: E=McAfee;i="6800,10657,11770"; a="82182113" X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="82182113" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 10:14:55 -0700 X-CSE-ConnectionGUID: JP/BgUDGSjKEL9JvPrffxQ== X-CSE-MsgGUID: AmjLvFq1SRKqxXD+tUGiPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="233975986" Received: from rgogar-mobl2.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.161.192]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 10:14:56 -0700 Date: Tue, 28 Apr 2026 10:14:54 -0700 Message-ID: <87ik9bj9bl.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v2] tests/intel/xe_oa: Wa_14026633728 In-Reply-To: <878qa85258.wl-ashutosh.dixit@intel.com> References: <20260427050002.3391994-1-shekhar.chauhan@intel.com> <878qa85258.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Sun, 26 Apr 2026 23:49:07 -0700, Dixit, Ashutosh wrote: > > On Sun, 26 Apr 2026 22:00:02 -0700, Shekhar Chauhan wrote: > > > > For MERTOA in CRI, oa buffer can be in device memory. Because of slower > > device mem access, OA exponent values lower than 8 can result in buffer > > overflows. Bump the OA exponent value. > > > > v2: Fix commit title, description and code description. > > > > Signed-off-by: Shekhar Chauhan > > --- > > tests/intel/xe_oa.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > > index 988c46df6..cbc1e0d3e 100644 > > --- a/tests/intel/xe_oa.c > > +++ b/tests/intel/xe_oa.c > > @@ -2645,6 +2645,16 @@ test_non_zero_reason(const struct drm_xe_oa_unit= *oau, size_t oa_buffer_size) > > { > > /* ~20 micro second period */ > > int oa_exponent =3D max_oa_exponent_for_period_lte(20000); > > + > > + /* > > + * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memo= ry. > > + * Because of slower device mem access, OA exponent values lower than= 8 can > > + * result in buffer overflows. > > + */ > > + > > This extra newline shouldn't be there. Anyway, I'll fix it up while > merging. Otherwise LGTM: > > Reviewed-by: Ashutosh Dixit Hmm, I missed this, not good: [116/1037] Compiling C object tests/xe_oa.p/intel_xe_oa.c.o ../tests/intel/xe_oa.c: In function =A1test_non_zero_reason=A2: ../tests/intel/xe_oa.c:2657:9: warning: ISO C90 forbids mixed declarations = and code [-Wdeclaration-after-statement] 2657 | struct intel_xe_perf_metric_set *test_set =3D oa_unit_metri= c_set(oau); | ^~~~~~ There should be no warnings when you compile! Please fix and resend the pat= ch. > > > + if (oau->oa_unit_type =3D=3D DRM_XE_OA_UNIT_TYPE_MERT && IS_CRESCENTI= SLAND(devid)) > > + oa_exponent =3D max(oa_exponent, 8); > > + > > struct intel_xe_perf_metric_set *test_set =3D oa_unit_metric_set(oau); > > uint64_t fmt =3D test_set->perf_oa_format; > > size_t report_size =3D get_oa_format(fmt).size; > > -- > > 2.53.0 > >