From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A25F3C36008 for ; Tue, 25 Mar 2025 18:48:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3944C10E4DA; Tue, 25 Mar 2025 18:48:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Yt03M4LB"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D34D310E4DA for ; Tue, 25 Mar 2025 18:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742928524; x=1774464524; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=yCd09gX/bOBJhBm7ZRz5lqZ7xTMwwr4e46WE/WylCCI=; b=Yt03M4LBm3sUN/Kfj/VvJgQMtz22yl7q+IIJrbZYJBMON4M3u0wzknsd i9GkrzCyRiPNfcK7Xu138sJ6P2AJ4kZzIhE+XgkoLiYuArm7MmwpqocPq ytCRppiFVRdG9KjyHUEXdzjRM42bAaH81ZBZWXV20zPDUvreWsXgmMKGl /Ud3lVwSKLOdXuZawcl5haYoJnq4KATArn/b3Kync0fp0FiS951VUA5w8 j+A8/NxFbHZBqDRNZ2CV9PtO1hbET2SpJEnwUHbST9cNlnEzWKIFCNbWB wY0ughAZ7ejABGv7WCx/p9dG54Aasg3PXTx7wd8J6reoo9znI79fCRHCN w==; X-CSE-ConnectionGUID: 68sMivf/QH2ApHhKKwkZkA== X-CSE-MsgGUID: YRhJ2LJDS+6oxLfNCawq3A== X-IronPort-AV: E=McAfee;i="6700,10204,11384"; a="47976307" X-IronPort-AV: E=Sophos;i="6.14,275,1736841600"; d="scan'208";a="47976307" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2025 11:48:42 -0700 X-CSE-ConnectionGUID: dS++mmVeQzugbIhncqdsyA== X-CSE-MsgGUID: HMcBfxIMQEGjM4Nf/MVKAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,275,1736841600"; d="scan'208";a="129135217" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.125.127.34]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2025 11:48:42 -0700 Date: Tue, 25 Mar 2025 11:48:41 -0700 Message-ID: <87iknxhrp2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sai Teja Pottumuttu Cc: , , , Subject: Re: [PATCH i-g-t] lib/intel_batchbuffer: Refactor igt_get_render_copyfunc In-Reply-To: <87h63hafvv.wl-ashutosh.dixit@intel.com> References: <20250324093627.3711195-1-sai.teja.pottumuttu@intel.com> <87h63hafvv.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 24 Mar 2025 21:33:24 -0700, Dixit, Ashutosh wrote: > > On Mon, 24 Mar 2025 02:36:27 -0700, Sai Teja Pottumuttu wrote: > > > > +++ b/lib/intel_batchbuffer.c > > @@ -652,9 +652,15 @@ void igt_blitter_fast_copy__raw(int fd, > > * specified with @devid. Will return NULL when no render copy function is > > * implemented. > > */ > > -igt_render_copyfunc_t igt_get_render_copyfunc(int devid) > > +igt_render_copyfunc_t igt_get_render_copyfunc(int fd) > > { > > igt_render_copyfunc_t copy = NULL; > > + int devid; > > + > > + if(is_xe_device(fd) && !xe_has_engine_class(fd, DRM_XE_ENGINE_CLASS_RENDER)) > > Needs a space after if. I can change that when merging, no need to > resend. Otherwise LGTM: > > Reviewed-by: Ashutosh Dixit > > But let's see if anyone else has any comments. I also fixed up comments for igt_get_render_copyfunc() and then merged this!